-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added all details about logic module #33
Conversation
@asmeurer Could you have a look at this too? |
>>> (y & x).subs({x: True, y: True}) | ||
True | ||
|
||
SOPform and POSform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mention this.
Please write this up in LaTeX format and include it in the paper. |
\subsubsection{Constructing boolean expressions} | ||
|
||
A boolean variable can be declared as a SymPy symbol. Python | ||
operators \&, \textbar and \textasciitilde are overloaded for logical \texttt{And}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\textbar{}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\textasciitilde{}
The examples have |
The above are just a shorthand, expressions can also be constructed | ||
by directly calling \texttt{And()}, \texttt{Or()}, \texttt{Not()}, | ||
\texttt{Xor()}, \texttt{Nand()}, \texttt{Nor()}, etc. | ||
The boolean symbols can also be substituted \texttt{True} or \texttt{False} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is similar to Line-5
@Sumith1896 Can you please address the comments here so that we can merge today? |
There seems to be extra references in the bib file. Maybe I fixed the merge conflicts the wrong way. Should I remove those references and keep only what I have used? |
Conflicts: features.tex paper.bib
@moorepants @certik ping |
@Sumith1896 I don't understand your question. Are you saying your PR added references that we don't need? I would remove them then. |
Cool, I think it is good to go for the first draft. I'll update the content accordingly as the paper evolves. |
@moorepants btw, we should add an error on unresolved references, as we currently have some. |
Thanks @certik |
I have included all the information about our
Logic
module in the txt file here for feedback on what has to be included and what not. AFAIK this is self contained, information has been collected from docs, code and references given in code.Once we decide on that, I'll make a fresh PR with the info added to
tex
with suitable examples and appropriate citations./cc @asmeurer @certik @moorepants @scopatz