Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all details about logic module #33

Merged
merged 7 commits into from
Apr 19, 2016
Merged

Conversation

Sumith1896
Copy link
Member

I have included all the information about our Logic module in the txt file here for feedback on what has to be included and what not. AFAIK this is self contained, information has been collected from docs, code and references given in code.

Once we decide on that, I'll make a fresh PR with the info added to tex with suitable examples and appropriate citations.

/cc @asmeurer @certik @moorepants @scopatz

@Sumith1896
Copy link
Member Author

@asmeurer Could you have a look at this too?

>>> (y & x).subs({x: True, y: True})
True

SOPform and POSform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mention this.

@asmeurer
Copy link
Member

Please write this up in LaTeX format and include it in the paper.

@Sumith1896 Sumith1896 changed the title Added all details about logic module (txt) Added all details about logic module Apr 15, 2016
\subsubsection{Constructing boolean expressions}

A boolean variable can be declared as a SymPy symbol. Python
operators \&, \textbar and \textasciitilde are overloaded for logical \texttt{And},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\textbar{}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\textasciitilde{}

@leosartaj
Copy link
Member

The examples have x, y, z, A, B, C, a, b, c. It can be difficult to follow along. This makes it harder to just copy paste and run the examples.

The above are just a shorthand, expressions can also be constructed
by directly calling \texttt{And()}, \texttt{Or()}, \texttt{Not()},
\texttt{Xor()}, \texttt{Nand()}, \texttt{Nor()}, etc.
The boolean symbols can also be substituted \texttt{True} or \texttt{False}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is similar to Line-5

@moorepants
Copy link
Member

@Sumith1896 Can you please address the comments here so that we can merge today?

@Sumith1896
Copy link
Member Author

There seems to be extra references in the bib file. Maybe I fixed the merge conflicts the wrong way. Should I remove those references and keep only what I have used?

Conflicts:
	features.tex
	paper.bib
@Sumith1896
Copy link
Member Author

@moorepants @certik ping

@certik
Copy link
Member

certik commented Apr 19, 2016

@Sumith1896 I don't understand your question. Are you saying your PR added references that we don't need? I would remove them then.

@Sumith1896
Copy link
Member Author

Cool, I think it is good to go for the first draft. I'll update the content accordingly as the paper evolves.

@certik
Copy link
Member

certik commented Apr 19, 2016

@moorepants btw, we should add an error on unresolved references, as we currently have some.

@certik certik merged commit 8313d07 into sympy:master Apr 19, 2016
@Sumith1896
Copy link
Member Author

Thanks @certik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants