New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible copyrighted image in the Beam docs #24388
Comments
can I make these diagrams by my own and add into the docs ? |
I wasn't aware of the possible copyright violation while making that pull request. Maybe we can use the draw function to create an image for these examples. |
Yes, that is the best solution. Please make SVG images if you do. |
Ok, I will. |
Looks good. Can you make the two supports clearly a pin on the left and a sphere (point contact) on the right? |
The black arrow on the top should align with the black dot between A and B also. |
Sorry, I was incorrect about this. You have it right. |
cm -> m |
If we are going to replace this, we should replace it with an SVG image that is editable. We shouldn't add bitmaps to the repo, as a general rule. |
We should just remove the image from the docs if we don't own the copyright to it. We can work on getting a replacement later. @Psycho-Pirate where did you get this image from? |
There are several png files in the repo: $ git ls-files | grep png
doc/src/_static/sympylogo.png
doc/src/_static/sympylogo_big.png
doc/src/modules/physics/continuum_mechanics/allowed-sign-conventions.png
doc/src/modules/physics/continuum_mechanics/ildreaction.png
doc/src/modules/physics/continuum_mechanics/ildshear.png
doc/src/modules/physics/continuum_mechanics/truss_example.png
doc/src/modules/physics/mechanics/examples/multidof-holonomic.png
doc/src/pics/consoleascii.png
doc/src/pics/consoleunicode.png
doc/src/pics/ipythonnotebook.png
doc/src/pics/ipythonqtconsole.png
doc/src/pics/pngview1.png
sympy/plotting/tests/test_region_and.png
sympy/plotting/tests/test_region_not.png
sympy/plotting/tests/test_region_or.png
sympy/plotting/tests/test_region_xor.png Presumably all the ones in doc/src/modules/physics should be removed and replaced with SVGs. The other png files are screenshots or other things which are not a problem. |
I've made a PR removing the questionable images at #24691. Like I said, we should still review the other images, and make SVGs for them otherwise. We can also make a replacement for these images, but they need to be removed regardless if we do not own the copyright for them. |
@Psycho-Pirate in the future, do not add anything to SymPy (images, code, or otherwise) unless you yourself explicitly created it. If it's something that someone else created, you need to make sure you have explicit permission, and include full attribution. SymPy's docs were already taken down before due to a false copyright claim (https://www.asmeurer.com/blog/posts/the-sympy-hackerrank-dmca-incident/). If we have things in the repo that we actually don't own the copyright to, it could result to the docs and the entire repo being taken down. And in general, do not add binary files like PNGs to the repo. There should be a very good reason to do so if you do. Images like this in the docs should be SVGs so that they take up less space in the repo and can be edited. |
can't i replace the existing ildreaction.png file and other png file with the ones i shared above |
@asTejaswinis did you construct those images yourself (including the image of the beam)? If so, you should be able to produce a vector version of the image from whatever program you used to construct it. If you did not, then we cannot include it, for the same reason we removed the original, unless you have explicit permission from whoever did produce them. |
By the way, the aspect ratios do not matter. The images are only used as figures. |
Yes, I have created the figures in 3d modeling software(Fusion 360) and labeled the snips of them using another software(simple photo editor). I will check if they can produce svg files |
The original PNG files have already been removed in #24691. I don't think we should add new figures unless they are vector images that we have the ability to edit in the future. |
I just noticed this image:
from:
https://docs.sympy.org/latest/modules/physics/continuum_mechanics/beam.html#sympy.physics.continuum_mechanics.beam.Beam.plot_ild_moment
It looks like a typical image from a text book and thus could possibly be a copyright violation in our docs.
The PR is #21810 and there seems to be no discussion over the use of the image.
The second issue is that it is a bitmap image instead of vector (e.g. svg).
This image should likely be removed unless the copyright can be verified.
cc @ishanaj @Psycho-Pirate
The text was updated successfully, but these errors were encountered: