-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use array in lambdify #7284
Comments
I'm currently working on this. As expressions are evaluated before |
Or MatMul, even with an ImmutableMatrix. |
As it remains unevaluated by default. |
The only way I can seem to manage to generate a MatMul expression is with multiplication between a MatrixSymbol, and something else. Multiplying two ImmutableMatrix objects evaluates, rather than returning a MatMul (unless that's not what you're saying). |
This will also happen if you replace a MatrixSymbol with an actual matrix in an expression (see #2962) |
Hmmm. Didn't realize you could create a |
Silly github, closing issues automatically just because people mention them in pull requests. The first part of this is fixed (removal of kwarg, use |
I think this can be deferred until later. It's at least no longer critical, as the I'm deferring this to 0.7.7, and removing the critical status. |
0.7.7, now 1.0, is coming up. What needs to be done here? |
See #2987 (comment) and #2931. We should just always use
array
, and print matrix multiplication asnp.dot
. We should revert the change from #2987. If you really want to use np.matrix, you can use the namespace option of lambdify.This should be done before the next release, at least the reversion of #2987 so that we don't add a new API that will then be removed.
The text was updated successfully, but these errors were encountered: