scipy in Lambdify #7229 #10319
scipy in Lambdify #7229 #10319
Conversation
Shekharrajak
changed the title
| from sympy.functions.special.hyper import * | ||
| from sympy.functions.special.hyper import * | ||
| from sympy.functions.special.gamma_functions import * | ||
| from sympy.functions.special.gamma_functions import * |
There was a problem hiding this comment.
Please don't use the from x import * style of import. Always make it explicit.
|
Why this error : |
|
Do you have it defined? Please post your whole code snippet that you are running? Or are you running the test? |
|
@moorepants , During running the tests in Travis that error is occurring.I did not define,that line is already there. |
| @@ -24,12 +24,12 @@ def eq(a, b, tol=1e-6): | |||
|
|
|||
| def test_jn_zeros(): | |||
| assert eq(jn_zeros(0, 4, method="scipy"), | |||
| [3.141592, 6.283185, 9.424777, 12.566370]) | |||
| [3.141592, 6.283185, 9.424777, 12.566370]) == True | |||
There was a problem hiding this comment.
test cases returns True so I think it will be better if we write it clearly., what is the output.
There was a problem hiding this comment.
The convention (see PEP8) is to not compare to True like this. It is unnecessary. Please revert.
| #Try if you can extract symbols from the expression. | ||
| #Move on if expr.atoms in not implemented. | ||
| # Try if you can extract symbols from the expression. | ||
| # Move on if expr.atoms in not implemented. |
There was a problem hiding this comment.
Please keep all of these kinds of fixes in a separate PR (or at least separate commit). I makes it difficult to focus on the actual code changes.
|
All of the formatting changes make it difficult to see the code changes. It is much more preferable and easier for the reviewers if you do formatting in a different PR. |
moorepants
added
utilities.lambdify
PR: author's turn
Shekharrajak
force-pushed
the
working#7229
branch
2 times, most recently
from
3c64b54
to
729909d
Compare
|
Use this module for testing: http://docs.scipy.org/doc/numpy-1.10.0/reference/routines.testing.html |
|
Check this modification |
7229