Interval(-oo,oo) contains oo and -oo #10343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just add 2 lines to handle (-oo,oo) case
| @@ -969,6 +969,8 @@ def _contains(self, other): | |||
|
|
|||
| if self.start is S.NegativeInfinity and self.end is S.Infinity: | |||
| if not other.is_real is None: | |||
| if other is S.NegativeInfinity or other is S.Infinity: | |||
| return false | |||
There was a problem hiding this comment.
I think, we can check for other belonging to extended reals without even checking self for the same.
Move infinities check to other_is_real
|
Ok, I move this check. |
|
Please add tests. |
|
I've never written tests. Something like this? |
|
Yep, perfect. |
asmeurer
added a commit
that referenced
this pull request
Jan 5, 2016
Interval(-oo,oo) contains oo and -oo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10326 issue
Just add 2 lines to handle (-oo,oo) case