-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #10785: Modified berkowitz_eigenvals() function #10786
Conversation
As the empty matrix have no minors, I think it would be better to return an empty tuple for the |
Now this would be the output for two modified functions(a is an Empty Matrix). |
@moorepants , sir please review this |
|
240 commits seem to be a lot. Can you update this with master? So only latest commits are shown. |
@leosartaj , thank you 😄 can this be in? |
@@ -3015,6 +3015,8 @@ def berkowitz_minors(self): | |||
|
|||
berkowitz | |||
""" | |||
if not self: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test necessary after berkowitz
has been modified to work with an empty matrix?
yeah, sorry. It is not necessary. I have created this before that. Thank you @jksuom . Can I close this now? |
It is not necessary to totally close the PR, the tests could remain.
I think you could leave these tests in this PR (with the first one properly edited). On the other hand, there seems to be no reason for special treatment of empty matrices in |
Looks good, thanks. |
This fixes the issue 10785.