Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

further diophantine modifications and isqrt added to core.powers #11094

Merged
merged 5 commits into from
May 10, 2016
Merged

further diophantine modifications and isqrt added to core.powers #11094

merged 5 commits into from
May 10, 2016

Conversation

smichr
Copy link
Member

@smichr smichr commented May 9, 2016

No description provided.

@smichr
Copy link
Member Author

smichr commented May 9, 2016

If there are no objections I'll commit in 24 hours.

I'm not sure how the use of var slipped into densesolve...I'm pretty sure we don't want that in the code base.

bjodah
bjodah reviewed May 9, 2016
View reviewed changes
sympy/core/power.py


def isqrt(n):
"""Return the largest integer lass than or equal to sqrt(n)."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"less than"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, got it

@smichr smichr merged commit a46587c into sympy:master May 10, 2016
@smichr smichr deleted the diop branch May 10, 2016 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smichr @bjodah