-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding UnevaluatedExpr() Tutorial #12232
Conversation
@Upabjojr , please review the changes . Thanks |
I would put the code here: (Advanced expression manipulation). |
Also link the class here: https://github.com/sympy/sympy/blob/master/doc/src/modules/core.rst#expr-1 |
@Upabjojr , I have changed it according to you, please review it . Thanks |
Strange... Travis did not start. |
doc/src/tutorial/manipulation.rst
Outdated
@@ -483,3 +483,49 @@ traversals easy. We could have also written our algorithm as | |||
have ``-x`` or ``1/x``. It is also done for speed efficiency because | |||
singletonized objects can be compared by ``is``. The unique objects for | |||
each singletonized class can be accessed from the ``S`` object. | |||
|
|||
``UnevaluatedExpr`` | |||
=================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tutorial should not be about the class UnevaluatedExpr
, rather about generic methods to keep expressions unevaluated. I think we should also mention evaluate=False
.
Added some fixes. Tests are probably still failing. |
@Upabjojr , do you know why the tests are failing ? |
Your example outputs are wrong. |
I checked it on terminal in sympy , it can't be wrong |
|
Maybe you use a different printer. |
I have updated the examples |
@Upabjojr , I checked all the examples once again . There doesn't seem any error in those . I would like to point to core.rst , because I am not really sure about that. |
https://travis-ci.org/sympy/sympy/jobs/206607119 There is still a minor problem. If tests fail, just click on the X near the commit hashtag to see why.
The doctests are generally sequential while executing the code, so different blocks are treated sequentially in every test. I think it's on a class-level or RST module-level (that is, higher scope is not sequential anymore), but I'm not so sure. |
@Upabjojr , I don't know why but the travis test is not opening up . This problem has been persistent since last night. |
Yeah, I think there's some problems with Travis today. I was able to access it one hour ago. Otherwise, run the tests locally. |
@Upabjojr , now I think its fine. One runtime error is due to some other module, I guess. |
That's our file. We need a shorter title. |
@Upabjojr , finally :) |
@Upabjojr , how can I run doc tests locally , because I can only see an error related to job time limit exceeded on Travis . Thanks |
I think that this time Travis had a spurious failure. Restarted. There is a directory |
@Upabjojr , I have run tests for other modules from bin by using the command like |
One of those scripts calls the command, just look at the code. |
This Pull Request Fixes #12230