Add general solution for the PDEs to the docstrings #12370
Conversation
sympy/solvers/pde.py
Outdated
|
|
||
| 2] `\eta` as the constant in the solution to the differential equation | ||
| `\frac{dy}{dx} = -\frac{b}{a}` | ||
| 2. `\eta` as the constant in the solution to the differentia |
There was a problem hiding this comment.
@gxyd, yes, it seems so. Thanks for the catch.
|
@nicoguaro can you please merge master branch in your PR? |
gxyd
added
the
PR: author's turn
|
I think I just did it. Let me know if that works |
|
It doesn't seem to have been merged. |
|
What should I do then? |
|
I can do that for you, that wouldn't be a problem. I just thought may want to do that on your own. Let me know if you want me to fix this for you. |
|
Well, I am not well versed in the use of Git. I thought that I had everything done when asked for this PR. But it seems that it is not true. Yes, please proceed. |
|
I'll review the PR tomorrow (its a little late already) and get back to you. |
sympy/solvers/pde.py
Outdated
| @@ -496,7 +496,12 @@ def pde_1st_linear_constant_coeff_homogeneous(eq, func, order, match, solvefun): | |||
|
|
|||
| where `a`, `b` and `c` are constants. | |||
|
|
|||
| The general solution is of the form:: | |||
| The general solution is of the form: | |||
|
|
|||
There was a problem hiding this comment.
There is trailing whitespace here, remove that please.
sympy/solvers/pde.py
Outdated
| where `a(x, y)`, `b(x, y)`, `c(x, y)` and `G(x, y)` are arbitrary functions | ||
| in `x` and `y`. This PDE is converted into an ODE by making the following transformation. | ||
| where `a(x, y)`, `b(x, y)`, `c(x, y)` and `G(x, y)` are arbitrary | ||
| functions in `x` and `y`. This PDE is converted into an ODE by |
There was a problem hiding this comment.
Also remove unnecessary space after 'functions'.
There was a problem hiding this comment.
What do you mean by "unnecessary space after functions"?
There was a problem hiding this comment.
There is some extra space after the word 'functions' in the beginning of this line, that isn't needed.
There was a problem hiding this comment.
Oh, I see. I'll fix it. Are we suppose to correct the source code to comply with PEP8?
There was a problem hiding this comment.
I am not sure if this is included in PEP8 or not. But since the current tests on travis fail because of this. That's why I suggested to change this.
There was a problem hiding this comment.
Ok, I think I made those changes.
|
@gxyd is there something else that need to be done with this? |
Remove excess indentation in docstring
Stats: Removed unused imports and improved documentation structure
Fixed imports, comments, and some bugs in printing
[WIP] Fixing is_zero for complex numbers in Add
Docs of is_convex has been improved and the reviews have been taken into account.
…nto concave_convex
Add test for matrix rank issue
Moved root_notation to correct alphabetical order
Clean up of series, combinatorics, codegen, and ntheory
Fix for wrong result from discrete logarithm
Update year in license
Improvements of multivariate resultants
Fix for finite fourier series
Remove an unreachable part of code
[WIP] Added Blum Goldwasser cryptosystem
Remove trailing spaces at line 500
Fix nth_algebraic to respect constants from the ODE
|
Hi, I am the SymPy bot (v137). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. ❌ There was an issue with the release notes. Please do not close this pull request; instead edit the description after reading the guide on how to write release notes.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed. |
sylee957
removed
the
PR: author's turn
No description provided.