Amended too long lines in conditionset.py #12491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smichr
reviewed
Apr 5, 2017
| @@ -39,10 +39,20 @@ def __new__(cls, sym, condition, base_set): | |||
| if isinstance(base_set, EmptySet): | |||
| return base_set | |||
| if isinstance(base_set, FiniteSet): | |||
| sifted = sift(base_set, lambda _: fuzzy_bool(condition.subs(sym, _))) | |||
There was a problem hiding this comment.
We tend to not prettify these too much. How about the following?
sifted = sift(base_set, lambda _: fuzzy_bool(
condition.subs(sym, _)))
return Union(FiniteSet(*sifted[True]), Basic.__new__(
cls, sym, condition, FiniteSet(*sifted[None])))
There was a problem hiding this comment.
Hi. Sure, I will fix this.
|
@Newman101 Maybe this can be merged once you change what was suggested. |
|
Sure, I will do these next. |
|
Took a while but it's done now - both tests ran locally, all green. |
|
I had restarted the failing test, it has passed now. Thanks, I am merging this. |
|
Good to know, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I rectified couple of issues with file sympy/sets/conditionset.py:
./bin/test quality executed locally - all green.
Thank you.