Stats probability uneval #1336
Merged
Stats probability uneval #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, something is obviously wrong with my branch. I must have polluted my master. |
Previously we sent the evaluate keyword downstream to Integral. Now we pop it off of kwargs instead of getting it.
|
Ok, things are better now. I'll run sympy-bot and merge in 24 hours if there are no questions/comments |
|
It seems to be a straightforward simple change. +1 from me. |
|
SymPy Bot Summary: ✳️ All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYy7sbDA Interpreter: /usr/bin/python2.5 (2.5.2-final-0) Automatic review by SymPy Bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed kwargs.get to kwargs.pop in probability method
Previously we sent the evaluate keyword downstream to Integral which caused an error.
Now we pop it off of kwargs instead of getting it.