Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect_const() changed argument #13702

Closed
wants to merge 2 commits into from
Closed

Conversation

vishalg2235
Copy link
Contributor

@gxyd Here collect_const argument is changed to collect_const(expr, *vars, Numbers=True).
I think docstring also should be changed with more examples to show all working aspects of collect_const.
#13683

@vishalg2235
Copy link
Contributor Author

ps: only check commit ee35c02 due to some mistake two commits has done.

@gxyd
Copy link
Contributor

gxyd commented Dec 8, 2017

There is already a PR #13684, focusing on trying to improve the documentation for collect_const. If you want to fix this issue, please try to improve the documentation for some other function satisfying the conditions described in the issue.

@vishalg2235
Copy link
Contributor Author

yup sure !

@vishalg2235 vishalg2235 closed this Dec 8, 2017
@gxyd
Copy link
Contributor

gxyd commented Dec 9, 2017

I think what you are doing wrong is that, you are checking out (using git checkout) a new branch, instead of checking out from the master branch. i.e. to say, that when you create a new branch, make sure you are present on the (updated) master branch.

@vishalg2235
Copy link
Contributor Author

yes @gxyd I realised the same thing when I was last pushing my commit. When I checkout from master branch and then push commit ,then it is not stacked with previous commit.

@vishalg2235
Copy link
Contributor Author

@gxyd should I delete this branch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants