Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence internationalization warnings #1432

Merged
merged 1 commit into from
Jul 19, 2012

Conversation

flacjacket
Copy link
Member

This doesn't necessarily fix the problems with internationalization, but it does silence the warnings that come up in the normal doc building and it doesn't make the i18n docs any worse (previously, none of the translations would show up at the bottom of the page, tho it tried to reference the Russian docs).

This doesn't necessarily fix the problems with internationalization, but
it does silence the warnings that come up in the normal doc building and
it doesn't make the i18n docs any worse (previously, none of the
translations would show up at the bottom of the page, tho it tries to
reference the Russian docs).
@asmeurer
Copy link
Member

I figured the fix would be something like this. I'm still confused about the difference between the Russian and German translations.

@travisbot
Copy link

This pull request passes (merged c3a4df2 into be3da02).

@asmeurer
Copy link
Member

I tried to run the bot tests for this (in your branch), but I got

Build finished. The HTML pages are in _build/html.
Switched to branch 'master'
Deleted branch test (was c3a4df2).
Return code:  0
> Done.
> Results logged to /var/folders/wc/dppcpmxs1tlb36nqcw853wkm0000gq/T/sympy-bot-tmpF08iwq/out/docs
> Uploading test results
Traceback (most recent call last):
  File "./sympy-bot", line 471, in <module>
    main()
  File "./sympy-bot", line 175, in main
    dispatch_reviews(options, urls, username=username, password=password)
  File "./sympy-bot", line 339, in dispatch_reviews
    "interpreter": i,
UnboundLocalError: local variable 'i' referenced before assignment

Anyway, the docs built, so I'm merging this...

asmeurer added a commit that referenced this pull request Jul 19, 2012
Silence internationalization warnings
@asmeurer asmeurer merged commit 82fe7dc into sympy:master Jul 19, 2012
@flacjacket
Copy link
Member Author

Ah, I put up a new commit on the bot to fix that. I get some error when I run the bot to build the docs, it looks for the mpmath plots in src/plots rather than src/modules/mpmath/plots. I'll have a review up soon showing this. I remember this coming up earlier, and I think it was version dependent, do you know what sphinx version you have?

EDIT: This came up before in #1030

@flacjacket
Copy link
Member Author

SymPy Bot Summary: 🔴 There were test failures.

@flacjacket: Please fix the test failures.

Build HTML Docs: 🔴 There were test failures.

Sphinx version: 1.1.3
Docs build command: make html-errors
master hash: 82fe7dc
branch hash: c3a4df2

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYu4IhDA

Automatic review by SymPy Bot.

@asmeurer
Copy link
Member

I guess 1.1.2. See my reviews at #1431.

@flacjacket
Copy link
Member Author

SymPy Bot Summary: 🔴 There were test failures.

@flacjacket: Please fix the test failures.

Build HTML Docs: 🔴 There were test failures.

Sphinx version: 1.1.2
Docs build command: make html-errors
master hash: 82fe7dc
branch hash: c3a4df2

Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYxdAhDA

Automatic review by SymPy Bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants