-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
continuum_mechanics : slope and deflection method now returns complete answer #14446
Conversation
@moorepants please review |
@moorepants can you please have a look, thanks! |
@jashan498 Please update wrt to master and add a release note. |
@jashan498 Can you explain why this doesn't affect all beams (the ones that already work)? |
…r of boundary_conditions are provided
✅ Hi, I am the SymPy bot (v124). I'm here to make sure this pull request has a release notes entry. Please read the guide on how to write release notes. Click here to see the pull request description that was parsed.
Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.2.1. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Update The release notes on the wiki have been updated. |
@moorepants actually it's due to the reason in most of our test cases we have provided all |
@@ -1040,9 +1040,12 @@ def deflection(self): | |||
conditions.append(((prev_def + deflection_value), args[i][1])) | |||
prev_def = deflection_value.subs(x, args[i][1].args[1]) | |||
return Piecewise(*conditions) | |||
return S(1)/(E*I)*integrate(integrate(self.bending_moment(), x), x) | |||
C3 = Symbol('C3') | |||
C4 = Symbol('C4') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a way for the user to set this symbol or access it. So either an optional argurment or an attribute, or both. They should be able to set the base character(s) or symbol or pass in a generator. SymPy has a generator for creating sequential symbols. cse uses it.
@moorepants I missed |
This job failed due to some |
Restarted. |
Thanks @jksuom ! |
Brief description of what is fixed or changed
Now for the above beam this integrates the bending_moment twice ignoring that for every integral a constant has to be added (which is solved with help of boundary conditions provided). 0n current master:
In case of
deflection
coefficient ofx
vanishes due to this.This sometimes is misleading, hence constants are required to mark the incomplete solution.
Release Notes