Stats: Corrections to conditions of type Or
#14578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, domain where conditions of type `Or` were valid was calculated
in a way that resulted in the condition being treated in the same way as
`And`. This PR is to fix this wrong result. Tests for the same have been
added.
Examples:
(Before Fix)```
>>> E = Exponential('E', 1)
>>> P(Or(E < 0, E > 0))
0
>>> P(Or(E > 1, E > 2)) == P(And(E > 1, E > 2))
True
```
(After fix)```
>>> E = Exponential('E', 1)
>>> P(Or(E < 0, E > 0))
1
>>> P(Or(E > 1, E > 2)) == P(E > 1)
True
```
asmeurer
reviewed
Apr 3, 2018
| @@ -484,8 +484,8 @@ def reduce_rational_inequalities_wrap(condition, var): | |||
| if condition.is_Relational: | |||
| return _reduce_inequalities([[condition]], var, relational=False) | |||
| if condition.__class__ is Or: | |||
There was a problem hiding this comment.
I know this isn't code you wrote, but this should be isinstance(condition, Or).
There was a problem hiding this comment.
Thanks for pointing that out. I have opened #14598 for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the domain where conditions of type
Orwere valid was calculatedin a way that resulted in the condition being treated in the same way as
And. This PR is to fix this wrong result. Tests for the same have beenadded.
Examples:
(Before Fix)
(After fix)
References to other Issues or PRs
Brief description of what is fixed or changed
Other comments