Failing python 3 pretty printing tests #1517
Conversation
|
I made some trivial docstring fixes so that I can run the bot on something to start with. |
|
Looks good...I suppose you want to wait for the bot tests before committing this? |
|
I'm putting this here so that I can run the bot on something, and add commits until I get it right. |
|
So, I seem to have found the fix in commit 5d4920c. I reverted the fix so that the bot and especially a change I made can be tested: https://github.com/sympy/sympy-bot/pull/130 |
|
Does this need to go in the release branch? |
|
This needs more testing. |
|
This is ready to go. |
|
Ok, checked all the commits, it all looks good, I'm +1 to merging. Lets wait a day or two to see if someone else wants to take a look; if no one merges it by then I will. @asmeurer I guess this should go in the release, it fixes failures in py3k. If you want to be more conservative, you can drop the docstring commits and the two about use2to3, leaving just the two fixing the failures. @jrioux, any thoughts? |
|
Let's get more people running their python3 bots against this PR. |
|
Good point. I'll try to do so when I can, but not before the weekend On 8/29/12, Julien Rioux notifications@github.com wrote:
Vladimir Perić |
|
It all still looks good to me but I defer to Aaron to decide where this should be merged (master or 072). |
|
If you want this to go in 0.7.2, please rebase it over that branch (you may need to use the --onto flag to rebase to move just these commits). |
|
At the moment I have no idea whether these fixes work for others as well as they do for me, so I wouldn't push to 0.7.2 without any more testing. |
|
SymPy Bot Summary: 🔴 Failed after merging jrioux/tests (32332fe0f45e7fc6c7938a435255703245e87bc6) into master (d208118). |
|
That looks good. Any more testers? |
|
I'm trying to figure out how to get internet to my laptop with Windows (as apparently that was where the issue arose?). If I can do it, I'll run the tests there. Or we can just merge it now and fix things later if they come up (definitely we want to test Windows before we do the final release). |
Check that the encoding used by stdout supports the characters that we are about to print. If not, replace the problematic characters by their backslash escaped form. This avoids the test runner from exiting early due to an UnicodeEncodeError while printing out test failures, from these files in particular: sympy/printing/pretty/tests/test_pretty.py sympy/physics/quantum/tests/test_printing.py
In python 3, printing tests fail if stdout uses an encoding different from utf8. The test runner is modified to take the encoding of stdout into account.
Keep a record of destination files and use it against the list of files in the destination folder, to identify and remove any lingering files. Fixes issue 3344.
|
The issue arose on linux with ISO 8859-1 as default encoding. Testing on windows would be nice, if you can manage it. |
|
I've rebased this so that it can be merged into either master or 0.7.2 as you see fit. |
|
It would be nice to have this in so that I can properly run the python 3 tests. |
Failing python 3 pretty printing tests
|
Changes Unknown when pulling 5c672d9 on jrioux:tests into * on sympy:master*. |
Pretty printing tests were failing on my machine under python 3. It's an encoding issue with the test runner. I fixed the test runner and now the tests pass.