Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ordinal(1)->1st: ordinal added to misc #15247

Merged
merged 1 commit into from
Sep 19, 2018
Merged

ordinal(1)->1st: ordinal added to misc #15247

merged 1 commit into from
Sep 19, 2018

Conversation

smichr
Copy link
Member

@smichr smichr commented Sep 15, 2018

References to other Issues or PRs

Brief description of what is fixed or changed

This utility function corrects and extends an inline version that is present in a Derivative error message. Since that error message (smthng like "Can't calculate the nth derivative wrt foo") can be rewritten without using an ordinal number (and is removed in a future commit) this function is not necessary.

Should we have it as a utility function?

Other comments

Release Notes

  • utilities
    • ordinal will convert an int to its ordinal representation, e.g. 12 -> 12th

@sympy-bot
Copy link

sympy-bot commented Sep 15, 2018

Hi, I am the SymPy bot (v132). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • utilities
    • ordinal will convert an int to its ordinal representation, e.g. 12 -> 12th (#15247 by @smichr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.4.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->


#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests .-->


#### Brief description of what is fixed or changed

This utility function corrects and extends an inline version that is present in a Derivative error message. Since that error message (smthng like "Can't calculate the nth derivative wrt foo") can be rewritten without using an ordinal number (and is removed in a future commit) this function is not necessary. 

Should we have it as a utility function?

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* utilities
  * ordinal will convert an int to its ordinal representation, e.g. 12 -> 12th

<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@asmeurer
Copy link
Member

asmeurer commented Sep 19, 2018

I'm assuming this is anticipated to be used somewhere else in the codebase. Looks fine to me.

@asmeurer asmeurer merged commit a74143d into sympy:master Sep 19, 2018
@smichr smichr deleted the d10 branch September 20, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants