Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added outputs for all plot examples #15366

Merged
merged 1 commit into from Oct 10, 2018
Merged

Conversation

iamprayush
Copy link
Contributor

@iamprayush iamprayush commented Oct 9, 2018

References to other Issues or PRs

#15327

Brief description of what is fixed or changed

Added outputs to all the plots using matplotlib plot directive

Other comments

This should be enough to close the issue.

Release Notes

  • plotting
    • Added outputs to all plotting examples in the sphinx docs.

@sympy-bot
Copy link

sympy-bot commented Oct 9, 2018

Hi, I am the SymPy bot (v134). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • plotting

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.4.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests .-->
#15327

#### Brief description of what is fixed or changed
Added outputs to all the plots using matplotlib plot directive

#### Other comments
This should be enough to close the issue.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* plotting
   * Added outputs to all plotting examples in the sphinx docs.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@iamprayush
Copy link
Contributor Author

These are the outputs that I received:
screenshot from 2018-10-10 00-17-30
screenshot from 2018-10-10 00-17-38
screenshot from 2018-10-10 00-17-43
screenshot from 2018-10-10 00-17-44
screenshot from 2018-10-10 00-17-47
screenshot from 2018-10-10 00-17-51

@iamprayush
Copy link
Contributor Author

@moorepants will this be enough to close the issue?

@moorepants
Copy link
Member

These look great. +1 to merge once tests pass.

@moorepants will this be enough to close the issue?

Maybe not. I think more work for the beam examples is still needed, among potential other places in the docs that use plots.

@iamprayush
Copy link
Contributor Author

These look great. +1 to merge once tests pass.

Awesome! Btw, when will the HTML files be updated to actually show these results in the sympy docs website?

And also, does this qualify me to be added in the AUTHORS list?

@moorepants
Copy link
Member

They are already there: https://docs.sympy.org/dev/modules/plotting.html

Yes, you will be added to the authors list on the next release.

@iamprayush
Copy link
Contributor Author

This error doesn't seem to be a consequence of the changes I made. @moorepants can you please confirm?

@moorepants moorepants merged commit 4851956 into sympy:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants