Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inconsistency in no. of arguments passed. #16071

Merged
merged 3 commits into from
Feb 25, 2019

Conversation

smichr
Copy link
Member

@smichr smichr commented Feb 25, 2019

dmp_gf_sqf_part takes at most 2 arguments but in dmp_sqf_part, 3 args are being passed

References to other Issues or PRs

closes #7612

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

sympy-bot commented Feb 25, 2019

Hi, I am the SymPy bot (v138). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

dmp_gf_sqf_part takes at most 2 arguments but in dmp_sqf_part, 3 args are being passed

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
closes #7612 

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

dmp_gf_sqf_part takes at most 2 arguments but in dmp_sqf_part, 3 args are being passed
lines matching `^([^>]+>) \1` are not necessary.
@jksuom
Copy link
Member

jksuom commented Feb 25, 2019

dmp-methods usually have the third argument u. Perhaps it should be added even if dmp_gf_sqf_part is currently not implemented yet.

If it is ever implemented, the `u` arg is now there like it is in other dmp routines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants