New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix negative indices in N-dim arrays #17669
Conversation
…ent, fixing with right assertions
…ent, fixing with right assertions
✅ Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
assert test_array[:, 3] == Array([4, 9]) | ||
assert test_array[:, 4] == Array([5, 10]) | ||
|
||
assert raises(ValueError, lambda: test_array[:, -6]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, raises
should be used without assert
.
Codecov Report
@@ Coverage Diff @@
## master #17669 +/- ##
=============================================
+ Coverage 74.699% 74.705% +0.006%
=============================================
Files 634 634
Lines 165544 165581 +37
Branches 38946 38955 +9
=============================================
+ Hits 123660 123698 +38
- Misses 36401 36402 +1
+ Partials 5483 5481 -2 |
Looks good to me if you're done. |
References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
Release Notes