`solve` now acknowledges `dict=True` for Relational args #17723

czgdp1807 · 2019-10-12T16:09:09Z

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

solvers
- solve now acknowledges dict=True for Relational args

Solve method will return a list of dictionaries for Relational args. Currently, it only supports solution with `And`, `Or` only.

sympy-bot · 2019-10-12T16:09:20Z

✅

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

solvers
- solve now acknowledges dict=True for Relational args (#17723 by @AtharvaKhare and @czgdp1807)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #13534
Closes #13540

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
  * `solve` now acknowledges `dict=True` for Relational args
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

czgdp1807 · 2019-10-12T16:12:03Z

ping @jksuom @asmeurer

czgdp1807 · 2019-10-12T16:45:21Z

What should solve([Eq(x, x), Eq(x, x+1)], x, dict=True) return? [] or [{}]?

sympy/solvers/tests/test_solvers.py

codecov · 2019-10-20T06:05:45Z

Codecov Report

Merging #17723 into master will increase coverage by 0.052%.
The diff coverage is 42.105%.

@@              Coverage Diff              @@
##            master    #17723       +/-   ##
=============================================
+ Coverage   74.689%   74.742%   +0.052%     
=============================================
  Files          634       633        -1     
  Lines       165811    166107      +296     
  Branches     38998     39077       +79     
=============================================
+ Hits        123844    124152      +308     
+ Misses       36480     36444       -36     
- Partials      5487      5511       +24

czgdp1807 · 2019-10-20T07:02:32Z

Someone, please help me with, https://travis-ci.org/sympy/sympy/jobs/600244489
I am unable to figure out why this is happening.

czgdp1807 · 2019-10-20T07:09:29Z

I am unable to figure out why this is happening.

Figured out. Thanks.

czgdp1807 · 2019-10-20T08:15:23Z

Since, all the tests are passing, the PR will be merged after 24 hours, if no critical objections are raised within the mentioned period. Thanks.

cbm755 · 2019-11-19T06:12:07Z

sympy/solvers/tests/test_solvers.py

+            (x, y, z,), dict=True) == [{x: 1, y: -1, z: 1}, {x: 1, y: 1, z: 1},
+                                       {x: 2, y: -1, z: 1}, {x: 2, y: 1, z: 1},
+                                       {x: 3, y: -1, z: 1}, {x: 3, y: 1, z: 1}]
+    assert solve(Gt(x, 0), (x,), dict=True) == And(Lt(0, x), Lt(x, oo))


@oscarbenjamin this last test is likely what is throwing the UserWarning (?)

cbm755 · 2019-11-19T06:19:27Z

sympy/solvers/solvers.py

+            if flags.get('dict', False):
+                solution = reduce_inequalities(f, symbols=symbols)
+                if isinstance(solution, Equality):
+                    return [{solution.lhs: solution.rhs}]


this looks bad, were are enumerating over things. We probably shouldn't return one of them...

Certainly no criticism intended to author of this. In particular I see other suspicious looking returns up above too! Line 973 and 975 for example...

czgdp1807 · 2019-11-19T06:23:37Z

@cbm755 Let me know if a follow up PR is needed for this.

cbm755 · 2019-11-19T06:28:37Z

I'm not sure, still learning here myself.... I guess it may get reverted for 1.5.

But I like your idea of having dict=True do its thing when it can! But maybe its needs some revision...

czgdp1807 · 2019-11-19T06:55:54Z

Refer, #11661 (comment)

reverted changes of #17723 for 1.5

AtharvaKhare and others added 4 commits October 26, 2017 10:33

FIX: solve acknowledges dict for Relational args

9c86189

Solve method will return a list of dictionaries for Relational args. Currently, it only supports solution with `And`, `Or` only.

FIX: Added tests for solve when dict=True

1d0dd55

resolved conflicts

269dbc4

completed pr

ffe6462

removed unwanted line

83a9161

czgdp1807 requested a review from aktech October 13, 2019 06:31

czgdp1807 added the solvers label Oct 13, 2019

oscarbenjamin reviewed Oct 13, 2019

View reviewed changes

sympy/solvers/tests/test_solvers.py Outdated Show resolved Hide resolved

czgdp1807 added 3 commits October 19, 2019 12:26

partial fix

8ec20ca

fix done

ced8700

minor fix

6c377a1

czgdp1807 merged commit 4c87ea3 into sympy:master Oct 21, 2019

oscarbenjamin mentioned this pull request Nov 18, 2019

regression: solve "Ignoring dict=True due to incompatible type" #17920

Closed

cbm755 reviewed Nov 19, 2019

View reviewed changes

cbm755 mentioned this pull request Nov 19, 2019

Solve: Output format don't consistent with ineq #11661

Closed

czgdp1807 added a commit to czgdp1807/sympy that referenced this pull request Nov 19, 2019

reverted changes of sympy#17723 for 1.5

542c72f

czgdp1807 mentioned this pull request Nov 19, 2019

reverted changes of #17723 for 1.5 #17925

Merged

cbm755 added a commit that referenced this pull request Nov 19, 2019

Merge pull request #17925 from czgdp1807/17723-pr-13540-revert

217921e

reverted changes of #17723 for 1.5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`solve` now acknowledges `dict=True` for Relational args #17723

`solve` now acknowledges `dict=True` for Relational args #17723

czgdp1807 commented Oct 12, 2019 •

edited

sympy-bot commented Oct 12, 2019 •

edited

czgdp1807 commented Oct 12, 2019

czgdp1807 commented Oct 12, 2019

codecov bot commented Oct 20, 2019 •

edited

czgdp1807 commented Oct 20, 2019

czgdp1807 commented Oct 20, 2019

czgdp1807 commented Oct 20, 2019

cbm755 Nov 19, 2019

cbm755 Nov 19, 2019

czgdp1807 commented Nov 19, 2019

cbm755 commented Nov 19, 2019

czgdp1807 commented Nov 19, 2019

solve now acknowledges dict=True for Relational args #17723

solve now acknowledges dict=True for Relational args #17723

Conversation

czgdp1807 commented Oct 12, 2019 • edited

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

sympy-bot commented Oct 12, 2019 • edited

czgdp1807 commented Oct 12, 2019

czgdp1807 commented Oct 12, 2019

codecov bot commented Oct 20, 2019 • edited

Codecov Report

czgdp1807 commented Oct 20, 2019

czgdp1807 commented Oct 20, 2019

czgdp1807 commented Oct 20, 2019

cbm755 Nov 19, 2019

Choose a reason for hiding this comment

cbm755 Nov 19, 2019

Choose a reason for hiding this comment

czgdp1807 commented Nov 19, 2019

cbm755 commented Nov 19, 2019

czgdp1807 commented Nov 19, 2019

`solve` now acknowledges `dict=True` for Relational args #17723

`solve` now acknowledges `dict=True` for Relational args #17723

czgdp1807 commented Oct 12, 2019 •

edited

sympy-bot commented Oct 12, 2019 •

edited

codecov bot commented Oct 20, 2019 •

edited