Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper_divisor and proper_divisor_count functions #18085

Merged
merged 4 commits into from
Dec 25, 2019

Conversation

czgdp1807
Copy link
Member

References to other Issues or PRs

Fixes #15927
#15928

Brief description of what is fixed or changed

Other comments

Release Notes

  • ntheory
    • Added proper_divisor and proper_divisor_count functions

@sympy-bot
Copy link

sympy-bot commented Dec 20, 2019

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #15927
https://github.com/sympy/sympy/pull/15928

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- ntheory
    - Added proper_divisor and proper_divisor_count functions
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@sylee957
Copy link
Member

Sphinx build is failing
Add these lines in ntheory.rst

.. autofunction:: proper_divisors

.. autofunction:: proper_divisor_count

@czgdp1807
Copy link
Member Author

Restarted the builds due to irrelevant failures in previous one.

@codecov
Copy link

codecov bot commented Dec 25, 2019

Codecov Report

Merging #18085 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##            master    #18085      +/-   ##
============================================
+ Coverage   74.884%   74.934%   +0.05%     
============================================
  Files          641       642       +1     
  Lines       166564    166965     +401     
  Branches     39179     39281     +102     
============================================
+ Hits        124730    125114     +384     
- Misses       36317     36318       +1     
- Partials      5517      5533      +16

@czgdp1807
Copy link
Member Author

@jksuom Is it ready to be merged? Please take a look.

@jksuom
Copy link
Member

jksuom commented Dec 25, 2019

Looks good to me.

@jksuom jksuom merged commit 3b6b1d9 into sympy:master Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function for proper divisors
4 participants