Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ValueError from meijerg #18141

Merged
merged 3 commits into from
Dec 27, 2019
Merged

Fixes ValueError from meijerg #18141

merged 3 commits into from
Dec 27, 2019

Conversation

Smit-create
Copy link
Member

@Smit-create Smit-create commented Dec 27, 2019

Fixes ValueError from meijerg in integrate module.

References to other Issues or PRs

Fixes #18133

Brief description of what is fixed or changed

It now produces the following output:

>>>integrate(exp(t)/(1+t)**2,t)
Integral(exp(t)/(t + 1)**2, t)

Other comments

Release Notes

  • integrals
    • Catch ValueError from meijerg() in _inverse_mellin_transform().

@sympy-bot
Copy link

sympy-bot commented Dec 27, 2019

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • integrals
    • Catch ValueError from meijerg() in _inverse_mellin_transform(). (#18141 by @Smit-create)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Fixes ValueError from meijerg in integrate module.
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #18133 

#### Brief description of what is fixed or changed
It now produces the following output:
```
>>>integrate(exp(t)/(1+t)**2,t)
Integral(exp(t)/(t + 1)**2, t)
```
#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* integrals
    * Catch ValueError from meijerg() in _inverse_mellin_transform().
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #18141 into master will decrease coverage by <.001%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #18141       +/-   ##
=============================================
- Coverage   74.949%   74.949%   -0.001%     
=============================================
  Files          642       642               
  Lines       166970    166973        +3     
  Branches     39283     39283               
=============================================
+ Hits        125144    125146        +2     
+ Misses       36305     36296        -9     
- Partials      5521      5531       +10

@jksuom
Copy link
Member

jksuom commented Dec 27, 2019

Please add a unit test.

@jksuom
Copy link
Member

jksuom commented Dec 27, 2019

Thanks, looks good.

@jksuom jksuom merged commit f7390e5 into sympy:master Dec 27, 2019
@Smit-create Smit-create deleted the 18133 branch January 3, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError from integrate, sympy 1.5
4 participants