-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Wrong Integral from SingleContinuousPSpace #18336
Conversation
✅ Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
@oscarbenjamin @czgdp1807 Does it seems good now?it is also applicable to all the continuous distributions. |
@czgdp1807 @oscarbenjamin Is it ready to merge? |
I left a couple of minor comments. This looks fine to me but I don't know the stats part of the codebase very well. |
@czgdp1807 Updated with suggested changes, Is this now ready to merge? |
LGTM. Will merge if no one objects for some time. Until then you can merge |
Codecov Report
@@ Coverage Diff @@
## master #18336 +/- ##
=============================================
+ Coverage 75.031% 75.293% +0.261%
=============================================
Files 649 633 -16
Lines 167370 166922 -448
Branches 39421 39391 -30
=============================================
+ Hits 125581 125682 +101
+ Misses 36249 35705 -544
+ Partials 5540 5535 -5 |
Fixes Wrong Integral from SingleContinuousPSpace.
References to other Issues or PRs
Fixes #10076
Brief description of what is fixed or changed
Before:
After:
Other comments
Release Notes