Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy printing support for some matrix expressions - revived #18351

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

sylee957
Copy link
Member

@sylee957 sylee957 commented Jan 16, 2020

References to other Issues or PRs

Fixes #17013, Fixes #17029, Fixes #17027

Brief description of what is fixed or changed

I made some changes to the conjugate transpose not to use the feature of the deprecated numpy.matrix. And made DiagonalOf return as a 2-dimensional column vector rather than a 1 dimensional vector.

Other comments

Release Notes

  • printing
    • Added NumPy printing for several matrix expressions. (ZeroMatrix, OneMatrix, FunctionMatrix, HadamardProduct, KroneckerProduct, Adjoint, DiagonalOf, DiagMatrix, DiagonalMatrix)

@sympy-bot
Copy link

sympy-bot commented Jan 16, 2020

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing
    • Added NumPy printing for several matrix expressions. (ZeroMatrix, OneMatrix, FunctionMatrix, HadamardProduct, KroneckerProduct, Adjoint, DiagonalOf, DiagMatrix, DiagonalMatrix) (#18351 by @sylee957 and @vighneshq)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->

Fixes #17013, Fixes #17029, Fixes #17027

#### Brief description of what is fixed or changed

I made some changes to the conjugate transpose not to use the feature of the deprecated `numpy.matrix`. And made `DiagonalOf` return as a 2-dimensional column vector rather than a 1 dimensional vector.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- printing
  - Added NumPy printing for several matrix expressions. (`ZeroMatrix`, `OneMatrix`, `FunctionMatrix`, `HadamardProduct`, `KroneckerProduct`, `Adjoint`, `DiagonalOf`, `DiagMatrix`, `DiagonalMatrix`)
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin
Copy link
Contributor

Looks good

@oscarbenjamin oscarbenjamin merged commit efdeb1f into sympy:master Jan 16, 2020
@sylee957 sylee957 deleted the numpy_matrix branch May 3, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing NumPy matrix expression printers
4 participants