-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Moyal Distribution #18446
Added Moyal Distribution #18446
Conversation
✅ Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Tests can be simplified after #18451. |
Codecov Report
@@ Coverage Diff @@
## master #18446 +/- ##
============================================
+ Coverage 75.319% 75.32% +0.001%
============================================
Files 639 640 +1
Lines 167150 167169 +19
Branches 39418 39428 +10
============================================
+ Hits 125896 125912 +16
- Misses 35710 35720 +10
+ Partials 5544 5537 -7 |
Diff coverage is low, can you see which coverable lines are missed? |
@czgdp1807 Please review. I don't know how diff coverage is changing, running locally it shows that I covered everything in the diff, also with the first commit the bot showed 100% diff coverage and then it got decreased surprisingly. |
It looks like an issue with Codecov, it is using incorrect diffs. LGTM. Will merge if no one objects for some time. |
Added Moyal Distribution
References to other Issues or PRs
#14881
Brief description of what is fixed or changed
Other comments
Release Notes