Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Moyal Distribution #18446

Merged
merged 8 commits into from
Jan 29, 2020
Merged

Added Moyal Distribution #18446

merged 8 commits into from
Jan 29, 2020

Conversation

Smit-create
Copy link
Member

@Smit-create Smit-create commented Jan 24, 2020

Added Moyal Distribution

References to other Issues or PRs

#14881

Brief description of what is fixed or changed

Other comments

Release Notes

  • stats
    • Added moyal distribution

@sympy-bot
Copy link

sympy-bot commented Jan 24, 2020

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Added Moyal Distribution
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
#14881

#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* stats
  * Added moyal distribution
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@ethankward
Copy link
Contributor

Tests can be simplified after #18451.

sympy/stats/crv_types.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #18446 into master will increase coverage by 0.001%.
The diff coverage is 74.509%.

@@             Coverage Diff              @@
##            master   #18446       +/-   ##
============================================
+ Coverage   75.319%   75.32%   +0.001%     
============================================
  Files          639      640        +1     
  Lines       167150   167169       +19     
  Branches     39418    39428       +10     
============================================
+ Hits        125896   125912       +16     
- Misses       35710    35720       +10     
+ Partials      5544     5537        -7

@czgdp1807
Copy link
Member

Diff coverage is low, can you see which coverable lines are missed?

@Smit-create
Copy link
Member Author

Screenshot from 2020-01-27 15-19-30

I am getting 100% diff coverage after removing numeric tests

@Smit-create
Copy link
Member Author

@czgdp1807 Please review. I don't know how diff coverage is changing, running locally it shows that I covered everything in the diff, also with the first commit the bot showed 100% diff coverage and then it got decreased surprisingly.

@czgdp1807
Copy link
Member

It looks like an issue with Codecov, it is using incorrect diffs. LGTM. Will merge if no one objects for some time.

@czgdp1807 czgdp1807 merged commit 0ce14be into sympy:master Jan 29, 2020
@Smit-create Smit-create deleted the moyal branch January 29, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants