Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockMatrix with 1 matrix can be converted into regular matrix #18621

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

abhinav-anand-addepar
Copy link
Member

@abhinav-anand-addepar abhinav-anand-addepar commented Feb 10, 2020

Fixes #18618

  • matrices
    • Fixed BlockDiagMatrix(A).blocks giving a non-block matrix.

@sympy-bot
Copy link

sympy-bot commented Feb 10, 2020

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Fixes #18618 

<!-- BEGIN RELEASE NOTES -->
* matrices
  * Fixed `BlockDiagMatrix(A).blocks` giving a non-block matrix.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@abhinav-anand-addepar abhinav-anand-addepar changed the title fixed issue fixed issue #18618 Feb 10, 2020
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #18621 into master will decrease coverage by 0.001%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #18621       +/-   ##
=============================================
- Coverage   75.585%   75.584%   -0.002%     
=============================================
  Files          644       644               
  Lines       167452    167452               
  Branches     39462     39462               
=============================================
- Hits        126570    126568        -2     
+ Misses       35364     35362        -2     
- Partials      5518      5522        +4

@oscarbenjamin
Copy link
Contributor

Can you give the PR a better title? It is very unclear from the title what this does

@abhinav-anand-addepar abhinav-anand-addepar changed the title fixed issue #18618 BlockMatrix with 1 element can be converted into regular matrix Feb 10, 2020
@smichr
Copy link
Member

smichr commented Feb 10, 2020

In the release notes do you mean "one matrix" or "a matrix with one element"? I suspect the latter.

@abhinav-anand-addepar abhinav-anand-addepar changed the title BlockMatrix with 1 element can be converted into regular matrix BlockMatrix with 1 matrix can be converted into regular matrix Feb 10, 2020
@sylee957 sylee957 merged commit 44664d9 into sympy:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockDiagMatrix with one element cannot be converted to regular Matrix
6 participants