Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated solvers-related test to test_solvers.py #18737

Closed
wants to merge 2 commits into from

Conversation

mohitacecode
Copy link
Contributor

References to other Issues or PRs

Partial fix for #18666

Brief description of what is fixed or changed

migrate all the solvers-related tests from test_matrices.py to a new created file test_solvers.py.

Other comments

Release Notes

  • matrices
    • Added test_solvers.py file which contain all the solvers-related tests.

@sympy-bot
Copy link

Hi, I am the SymPy bot (v157). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • matrices
    • Added test_solvers.py file which contain all the solvers-related tests. (#18737 by @mohitacecode)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Partial fix for #18666

#### Brief description of what is fixed or changed
migrate all the `solvers-related tests` from `test_matrices.py`  to a new created file `test_solvers.py`.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
*   matrices
     *  Added `test_solvers.py` file which contain all the solvers-related tests.
<!-- END RELEASE NOTES -->

@sympy-bot
Copy link

sympy-bot commented Feb 27, 2020

🟠

Hi, I am the SymPy bot (v157). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it.

This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75.

The following commits add new files:

  • fd7daec:
    • sympy/matrices/tests/test_solvers.py

If these files were added/deleted on purpose, you can ignore this message.

@sylee957
Copy link
Member

sylee957 commented Mar 1, 2020

This has merge conflicts now

@mohitacecode
Copy link
Contributor Author

This has merge conflicts now

Okay I will solve it soon.

@sylee957
Copy link
Member

sylee957 commented Mar 9, 2020

Unfortunately, #18793 had arrived to the solution faster, so I may close this.

@sylee957 sylee957 closed this Mar 9, 2020
@mohitacecode mohitacecode deleted the issue_18666_5 branch April 15, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants