-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NumPyPrinter to give the minimum over the first axis. #18774
Conversation
✅ Hi, I am the SymPy bot (v157). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like: This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #18774 +/- ##
=============================================
- Coverage 75.661% 75.651% -0.010%
=============================================
Files 647 647
Lines 168420 168420
Branches 39681 39682 +1
=============================================
- Hits 127429 127413 -16
- Misses 35442 35454 +12
- Partials 5549 5553 +4 |
Can you also add some tests? |
I am adding it . |
Lambdify only takes numpy array as an input, it discards regular python array. |
The reason that your tests are failing is because you have not made that as an optional dependency test. |
Look at how the other lambdify tests are written, so that they skip the test if numpy is not available. |
I fixed the release notes entry. Please keep them so they are relevant to end-users, not referencing implementation details. |
I will keep that in mind |
References to other Issues or PRs
Fixes #18770
Fixes #18742
Brief description of what is fixed or changed
Added axis=0 at the end of the _print_Min() and _print_Max() to give minimum/maximum over the first axis of an array.
amin((x + 1,0.1x + 3,0.5x + 1)) got updated to amin((x + 1,0.1x + 3,0.5x + 1), axis=0).
Other comments
Please suggest changes.
Release Notes
Min
/Max
for arrays of more than one dimension