Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate nested floor/ceiling. #18903

Merged
merged 3 commits into from Mar 19, 2020
Merged

Evaluate nested floor/ceiling. #18903

merged 3 commits into from Mar 19, 2020

Conversation

sbt4104
Copy link
Contributor

@sbt4104 sbt4104 commented Mar 18, 2020

References to other Issues or PRs

Fixes #18689

Brief description of what is fixed or changed

evaluate nested floor and ceiling.
example-

floor(floor(floor(x)) + 3) == floor(x) + 3
ceiling(ceiling(ceiling(x)) + 3) == ceiling(x) + 3
ceiling(ceiling(floor(x)) + 3) == floor(x) + 3

Release Notes

  • functions
    • Evaluate nested floor/ceiling.

@sympy-bot
Copy link

sympy-bot commented Mar 18, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

#### References to other Issues or PRs
Fixes #18689 

#### Brief description of what is fixed or changed
evaluate nested floor and ceiling.
example-
```python
floor(floor(floor(x)) + 3) == floor(x) + 3
ceiling(ceiling(ceiling(x)) + 3) == ceiling(x) + 3
ceiling(ceiling(floor(x)) + 3) == floor(x) + 3
```
### Release Notes
<!-- BEGIN RELEASE NOTES -->
* functions
    - Evaluate nested floor/ceiling.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@Smit-create
Copy link
Member

Please add test cases for the change you have made

Improve condtion to check nested floor/ceiling.
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #18903 into master will increase coverage by 0.012%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #18903       +/-   ##
=============================================
+ Coverage   75.649%   75.662%   +0.012%     
=============================================
  Files          647       647               
  Lines       168517    168520        +3     
  Branches     39707     39710        +3     
=============================================
+ Hits        127483    127507       +24     
+ Misses       35474     35456       -18     
+ Partials      5560      5557        -3

@smichr
Copy link
Member

smichr commented Mar 19, 2020

Looks good.

@smichr smichr merged commit d984395 into sympy:master Mar 19, 2020
@sbt4104 sbt4104 deleted the evaluate_nester_floor-ceiling branch March 19, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested floor and ceiling don't fully evaluate
5 participants