New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Airy functionality to the SciPyPrinter class #18908
Conversation
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
You have trailing whitespaces in your file, please fix those. You can run the code quality test locally using |
That is correct, sorry i thought i ran that test. Fixed. |
Codecov Report
@@ Coverage Diff @@
## master #18908 +/- ##
=============================================
- Coverage 75.678% 75.678% -0.001%
=============================================
Files 647 647
Lines 168518 168528 +10
Branches 39709 39710 +1
=============================================
+ Hits 127532 127539 +7
+ Misses 35434 35432 -2
- Partials 5552 5557 +5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, fixed.
References to other Issues or PRs
Fixes #17396
Brief description of what is fixed or changed
The SciPyPrinter class still does not support all of the special functions, and so functions should be added to it, this adds functions airyai, airybi, airyaiprime, airybiprime from sympy to the SciPyPrinter class, these all map to scipy.special.airy with the correct index of the output.
Other comments
Tests are also added, currently neither Python nor Numpy supports these functions.
Release Notes