Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Airy functionality to the SciPyPrinter class #18908

Merged
merged 1 commit into from Mar 20, 2020

Conversation

OmarWagih1
Copy link
Contributor

References to other Issues or PRs

Fixes #17396

Brief description of what is fixed or changed

The SciPyPrinter class still does not support all of the special functions, and so functions should be added to it, this adds functions airyai, airybi, airyaiprime, airybiprime from sympy to the SciPyPrinter class, these all map to scipy.special.airy with the correct index of the output.

Other comments

Tests are also added, currently neither Python nor Numpy supports these functions.

Release Notes

  • printing
    • Added support for airy functions in the SciPyPrinter class.

@sympy-bot
Copy link

sympy-bot commented Mar 18, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing
    • Added support for airy functions in the SciPyPrinter class. (#18908 by @OmarWagih1)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
Fixes #17396 


#### Brief description of what is fixed or changed

The SciPyPrinter class still does not support all of the special functions, and so functions should be added to it, this adds functions airyai, airybi, airyaiprime, airybiprime from sympy to the SciPyPrinter class, these all map to scipy.special.airy with the correct index of the output.

#### Other comments

Tests are also added, currently neither Python nor Numpy supports these functions.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* printing
  * Added support for airy functions in the SciPyPrinter class.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@Sc0rpi0n101
Copy link
Member

Sc0rpi0n101 commented Mar 19, 2020

You have trailing whitespaces in your file, please fix those.

You can run the code quality test locally using bin/test quality and remove the trailing whitespaces using bin/strip_whitespace <file>. Check out https://github.com/sympy/sympy/wiki/Development-workflow#be-sure-that-all-tests-of-sympy-pass for reference.

@OmarWagih1
Copy link
Contributor Author

You have trailing whitespaces in your file, please fix those.

You can run the code quality test locally using bin/test quality and remove the trailing whitespaces using bin/strip_whitespace <file>. Check out https://github.com/sympy/sympy/wiki/Development-workflow#be-sure-that-all-tests-of-sympy-pass for reference.

That is correct, sorry i thought i ran that test.

Fixed.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #18908 into master will decrease coverage by <.001%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master    #18908       +/-   ##
=============================================
- Coverage   75.678%   75.678%   -0.001%     
=============================================
  Files          647       647               
  Lines       168518    168528       +10     
  Branches     39709     39710        +1     
=============================================
+ Hits        127532    127539        +7     
+ Misses       35434     35432        -2     
- Partials      5552      5557        +5

sympy/printing/pycode.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@OmarWagih1 OmarWagih1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more SciPy functions to code printer
5 participants