-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_holonomic caching error #19236
fix_holonomic caching error #19236
Conversation
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
|
the tests pass now, @oscarbenjamin @jksuom |
There is another case a few lines earlier. Maybe that should be changed as well. |
Codecov Report
@@ Coverage Diff @@
## master #19236 +/- ##
=============================================
+ Coverage 75.650% 75.680% +0.029%
=============================================
Files 651 651
Lines 169488 169486 -2
Branches 40021 40021
=============================================
+ Hits 128219 128268 +49
+ Misses 35652 35604 -48
+ Partials 5617 5614 -3 |
@oscarbenjamin, this could be included in the 1.6 release. |
Yes, it could. To make that happen do this:
|
@smichr @oscarbenjamin I've done this #19236 (comment) |
References to other Issues or PRs
Fixes #19222
Brief description of what is fixed or changed
Fixes a cache mismatch due to using
is
instead of==
inholonomic.py
Other comments
Release Notes
NO ENTRY