Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_holonomic caching error #19236

Merged
merged 2 commits into from
May 4, 2020
Merged

Conversation

iammosespaulr
Copy link
Contributor

@iammosespaulr iammosespaulr commented May 1, 2020

References to other Issues or PRs

Fixes #19222

Brief description of what is fixed or changed

Fixes a cache mismatch due to usingis instead of == in holonomic.py

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

sympy-bot commented May 1, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Fixes #19222

#### Brief description of what is fixed or changed

Fixes a cache mismatch due to using`is` instead of `==` in `holonomic.py`

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@iammosespaulr
Copy link
Contributor Author

the tests pass now, @oscarbenjamin @jksuom

@jksuom
Copy link
Member

jksuom commented May 1, 2020

There is another case a few lines earlier. Maybe that should be changed as well.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #19236 into master will increase coverage by 0.029%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #19236       +/-   ##
=============================================
+ Coverage   75.650%   75.680%   +0.029%     
=============================================
  Files          651       651               
  Lines       169488    169486        -2     
  Branches     40021     40021               
=============================================
+ Hits        128219    128268       +49     
+ Misses       35652     35604       -48     
+ Partials      5617      5614        -3     

@smichr
Copy link
Member

smichr commented May 3, 2020

@oscarbenjamin, this could be included in the 1.6 release.

@oscarbenjamin
Copy link
Contributor

@oscarbenjamin, this could be included in the 1.6 release.

Yes, it could. To make that happen do this:

  1. Leave this unmerged for now.
  2. Open a new PR from the same branch but against the 1.6 branch - add the release note there.
  3. I'll merge it into 1.6.
  4. Remove the release note here and merge it into master.

@iammosespaulr
Copy link
Contributor Author

@smichr @oscarbenjamin I've done this #19236 (comment)

@iammosespaulr iammosespaulr mentioned this pull request May 4, 2020
@oscarbenjamin oscarbenjamin merged commit 3a6f292 into sympy:master May 4, 2020
@iammosespaulr iammosespaulr deleted the fix_holonomic branch September 4, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'sympy/holonomic/tests/test_holonomic.py' fails on master
6 participants