Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix holonomic #19248

Merged
merged 2 commits into from
May 4, 2020
Merged

Fix holonomic #19248

merged 2 commits into from
May 4, 2020

Conversation

iammosespaulr
Copy link
Contributor

@iammosespaulr iammosespaulr commented May 3, 2020

References to other Issues or PRs

Same as #19236 but for the 1.6 branch.

Brief description of what is fixed or changed

Fixes a cache mismatch due to usingis instead of == in holonomic.py

Other comments

Release Notes

  • holonomic
    • A cache mismatch error was fixed.

@sympy-bot
Copy link

sympy-bot commented May 3, 2020

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Same as #19236 but for the 1.6 branch.

#### Brief description of what is fixed or changed

Fixes a cache mismatch due to using`is` instead of `==` in `holonomic.py`

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* holonomic
  * A cache mismatch error was fixed.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin oscarbenjamin added this to the SymPy 1.6 milestone May 3, 2020
@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #19248 into 1.6 will increase coverage by 0.006%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##               1.6    #19248       +/-   ##
=============================================
+ Coverage   75.650%   75.657%   +0.006%     
=============================================
  Files          651       651               
  Lines       169488    169565       +77     
  Branches     40021     40056       +35     
=============================================
+ Hits        128219    128289       +70     
- Misses       35652     35665       +13     
+ Partials      5617      5611        -6     

@smichr
Copy link
Member

smichr commented May 4, 2020

@oscarbenjamin , shall I leave this unmerged so you can do all the passing 1.6 milestone PRs at once?

@oscarbenjamin oscarbenjamin merged commit fa01809 into sympy:1.6 May 4, 2020
@iammosespaulr iammosespaulr deleted the fix_holonomic branch September 4, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants