Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for #19739 #19743

Merged
merged 2 commits into from Jul 11, 2020
Merged

Add regression test for #19739 #19743

merged 2 commits into from Jul 11, 2020

Conversation

aaryandewan
Copy link
Contributor

@aaryandewan aaryandewan commented Jul 11, 2020

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY
Fixes #19739

@sympy-bot
Copy link

sympy-bot commented Jul 11, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

sympy/series/tests/test_limits.py Show resolved Hide resolved
@@ -845,3 +845,6 @@ def test_issue_13715():

def test_issue_15055():
assert limit(n**3*((-n - 1)*sin(1/n) + (n + 2)*sin(1/(n + 1)))/(-n + 1), n, oo) == 1

def test_issue_19739():
assert limit((-1/4)**n, n, oo) == 0
Copy link
Contributor

@sachin-4099 sachin-4099 Jul 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be assert limit((-S(1)/4)**x, x, oo) == 0. x should be used and not n.

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 11, 2020

The Release Notes should have NO ENTRY.

Added 2 line spacing. Changed `n` to `x`
@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #19743 into master will increase coverage by 0.015%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master    #19743       +/-   ##
=============================================
+ Coverage   75.707%   75.723%   +0.015%     
=============================================
  Files          659       660        +1     
  Lines       171329    171507      +178     
  Branches     40415     40458       +43     
=============================================
+ Hits        129709    129871      +162     
- Misses       35977     35978        +1     
- Partials      5643      5658       +15     

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 11, 2020

Looks good to me. This can be merged @jksuom.

@Smit-create
Copy link
Member

Smit-create commented Jul 11, 2020

@aaryandewan Add Fixes #issue_number in the release notes so that the issue gets closed upon merging this automatically

@smichr smichr merged commit 530f917 into sympy:master Jul 11, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit with negative base
6 participants