-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for #19739 #19743
Conversation
✅ Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
|
sympy/series/tests/test_limits.py
Outdated
@@ -845,3 +845,6 @@ def test_issue_13715(): | |||
|
|||
def test_issue_15055(): | |||
assert limit(n**3*((-n - 1)*sin(1/n) + (n + 2)*sin(1/(n + 1)))/(-n + 1), n, oo) == 1 | |||
|
|||
def test_issue_19739(): | |||
assert limit((-1/4)**n, n, oo) == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be assert limit((-S(1)/4)**x, x, oo) == 0
. x
should be used and not n
.
The Release Notes should have |
Added 2 line spacing. Changed `n` to `x`
Codecov Report
@@ Coverage Diff @@
## master #19743 +/- ##
=============================================
+ Coverage 75.707% 75.723% +0.015%
=============================================
Files 659 660 +1
Lines 171329 171507 +178
Branches 40415 40458 +43
=============================================
+ Hits 129709 129871 +162
- Misses 35977 35978 +1
- Partials 5643 5658 +15 |
Looks good to me. This can be merged @jksuom. |
@aaryandewan Add |
References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
Release Notes
NO ENTRY
Fixes #19739