Add regression test for #19739#19743
Merged
smichr merged 2 commits intosympy:masterfrom Jul 11, 2020
aaryandewan:master
Merged
Conversation
|
✅ Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed. |
sachin-4099
reviewed
Jul 11, 2020
| assert limit(n**3*((-n - 1)*sin(1/n) + (n + 2)*sin(1/(n + 1)))/(-n + 1), n, oo) == 1 | ||
|
|
||
| def test_issue_19739(): | ||
| assert limit((-1/4)**n, n, oo) == 0 No newline at end of file |
Contributor
There was a problem hiding this comment.
This should be assert limit((-S(1)/4)**x, x, oo) == 0. x should be used and not n.
Contributor
|
The Release Notes should have |
Added 2 line spacing. Changed `n` to `x`
Codecov Report
@@ Coverage Diff @@
## master #19743 +/- ##
=============================================
+ Coverage 75.707% 75.723% +0.015%
=============================================
Files 659 660 +1
Lines 171329 171507 +178
Branches 40415 40458 +43
=============================================
+ Hits 129709 129871 +162
- Misses 35977 35978 +1
- Partials 5643 5658 +15 |
Contributor
|
Looks good to me. This can be merged @jksuom. |
Member
|
@aaryandewan Add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
Release Notes
NO ENTRY
Fixes #19739