Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 11672 test #19749

Merged
merged 3 commits into from
Jul 12, 2020
Merged

add 11672 test #19749

merged 3 commits into from
Jul 12, 2020

Conversation

goddus
Copy link
Contributor

@goddus goddus commented Jul 11, 2020

References to other Issues or PRs

Fixes #11672

Release Notes

NO ENTRY

@sympy-bot
Copy link

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #11672 


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@sachin-4099
Copy link
Contributor

sachin-4099 commented Jul 12, 2020

I guess you are struggling to make a correct PR.

First of all, you should update the master branch on your local machine with sympy's master by running the command:

  1. git pull on your master branch

Then, you should create a new branch by running the command:

  1. git branch <branch_name> and checkout to that branch using git checkout <branch_name>

Make the required changes on the new branch and before committing the changes you should run: bin/test quality to make sure that the files you are changing have no trailing whitespace.

Finally, you should commit those changes and make the PR.

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #19749 into master will decrease coverage by 11.268%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##            master    #19749        +/-   ##
==============================================
- Coverage   75.703%   64.434%   -11.269%     
==============================================
  Files          662       662                
  Lines       172093    172163        +70     
  Branches     40588     40604        +16     
==============================================
- Hits        130281    110933     -19348     
- Misses       36125     54914     +18789     
- Partials      5687      6316       +629     

@jksuom
Copy link
Member

jksuom commented Jul 12, 2020

Thanks!

@jksuom jksuom merged commit 49ea879 into sympy:master Jul 12, 2020
@goddus goddus deleted the 11672_test branch July 20, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit(Rational(-1,2)**k, k, oo) fails
6 participants