Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latex parsing of not equal, less than, greater than #19970

Merged
merged 6 commits into from Aug 30, 2020
Merged

Latex parsing of not equal, less than, greater than #19970

merged 6 commits into from Aug 30, 2020

Conversation

bhpayne
Copy link
Contributor

@bhpayne bhpayne commented Aug 16, 2020

References to other Issues or PRs

no issues related to neq in Latex

Brief description of what is fixed or changed

added support for \neq in Latex based on @iammosespaulr 's work, and expanded less than, greater than support in Latex

Other comments

Release Notes

  • parsing
    • added Latex support for "not equal" and expanded support for less than, greater than symbols

NEQ and more less than, greater than varients
from @immosespaulr
@sympy-bot
Copy link

sympy-bot commented Aug 16, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • parsing
    • added Latex support for "not equal" and expanded support for less than, greater than symbols (#19970 by @bhpayne)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

#### References to other Issues or PRs
no issues related to neq in Latex

#### Brief description of what is fixed or changed
added support for \neq in Latex based on @iammosespaulr 's work, and expanded less than, greater than support in Latex

#### Other comments


#### Release Notes

<!-- BEGIN RELEASE NOTES -->
* parsing
  * added Latex support for "not equal" and expanded support for less than, greater than symbols
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@bhpayne
Copy link
Contributor Author

bhpayne commented Aug 18, 2020

The failed test appears to be a timeout

The job exceeded the maximum time limit for jobs, and has been terminated.

@bhpayne
Copy link
Contributor Author

bhpayne commented Aug 23, 2020

I tested this branch locally on my computer using both

>>> sympy.test()
>>> sympy.test("sympy/parsing/tests/test_latex.py")

The first took 2 hours; the second took 4.5 seconds. Both passed.

@oscarbenjamin
Copy link
Contributor

I've restarted the test that timed out. Maybe it's just a momentary problem on the test server

@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #19970 into master will decrease coverage by 17.612%.
The diff coverage is 0.000%.

@@              Coverage Diff               @@
##            master    #19970        +/-   ##
==============================================
- Coverage   75.832%   58.219%   -17.613%     
==============================================
  Files          669       669                
  Lines       173451    173504        +53     
  Branches     40903     40908         +5     
==============================================
- Hits        131532    101014     -30518     
- Misses       36196     66141     +29945     
- Partials      5723      6349       +626     

@czgdp1807
Copy link
Member

Is it good to merge? @iammosespaulr @oscarbenjamin

@sylee957 sylee957 merged commit b942813 into sympy:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants