New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .evalf() to Vector and Dyadic #20396
Conversation
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #20396 +/- ##
=============================================
- Coverage 75.771% 75.759% -0.012%
=============================================
Files 673 673
Lines 174110 174144 +34
Branches 41106 41112 +6
=============================================
+ Hits 131925 131930 +5
- Misses 36467 36501 +34
+ Partials 5718 5713 -5 |
@moorepants I have added .evalf() to Dyadic and Vector classes. Please review . |
@moorepants I have updated the test case. Please review. |
LGTM other than the minor comments. |
@moorepants I have done the reviewed changes. |
Thanks! |
@moorepants Is there any other method required to be added in these two classes? |
|
I'll work on that now. |
References to other Issues or PRs
Fixes #18064
Fixes #18310
Fixes #18559
Brief description of what is fixed or changed
Introduced .evalf() to Dyadic and Vector class.
Other comments
Release Notes