Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .evalf() to Vector and Dyadic #20396

Merged
merged 18 commits into from Nov 17, 2020
Merged

Added .evalf() to Vector and Dyadic #20396

merged 18 commits into from Nov 17, 2020

Conversation

sidhu1012
Copy link
Contributor

References to other Issues or PRs

Fixes #18064
Fixes #18310
Fixes #18559

Brief description of what is fixed or changed

Introduced .evalf() to Dyadic and Vector class.

Other comments

Release Notes

  • physics.vector
    • Added .evalf() to Vector class
    • Added .evalf() to Dyadic class

@sympy-bot
Copy link

sympy-bot commented Nov 8, 2020

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #18064 
Fixes #18310
Fixes #18559

#### Brief description of what is fixed or changed
Introduced .evalf() to Dyadic and Vector class.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- physics.vector
     - Added .evalf() to Vector class
     - Added .evalf() to Dyadic class
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #20396 (9671a84) into master (65e7294) will decrease coverage by 0.011%.
The diff coverage is 84.615%.

@@              Coverage Diff              @@
##            master    #20396       +/-   ##
=============================================
- Coverage   75.771%   75.759%   -0.012%     
=============================================
  Files          673       673               
  Lines       174110    174144       +34     
  Branches     41106     41112        +6     
=============================================
+ Hits        131925    131930        +5     
- Misses       36467     36501       +34     
+ Partials      5718      5713        -5     

@sidhu1012
Copy link
Contributor Author

sidhu1012 commented Nov 9, 2020

@moorepants I have added .evalf() to Dyadic and Vector classes. Please review .

@sidhu1012
Copy link
Contributor Author

@moorepants I have updated the test case. Please review.

@moorepants
Copy link
Member

LGTM other than the minor comments.

@sidhu1012
Copy link
Contributor Author

@moorepants I have done the reviewed changes.

@moorepants moorepants merged commit 1abbc0a into sympy:master Nov 17, 2020
@moorepants
Copy link
Member

Thanks!

@sidhu1012
Copy link
Contributor Author

sidhu1012 commented Nov 18, 2020

@moorepants Is there any other method required to be added in these two classes?

@moorepants
Copy link
Member

.xreplace() is another one.

@sidhu1012
Copy link
Contributor Author

.xreplace() is another one.

I'll work on that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .evalf() method to sympy.physics.vector.Vector and Dyadic
6 participants