New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cxx printing for Min/Max #20558
Fix cxx printing for Min/Max #20558
Conversation
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Thanks for sending the fix @FFroehlich . If possible, could you please add a regression test for this fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the patch. I concur, a test would be nice. Otherwise, +1 from me.
Codecov Report
@@ Coverage Diff @@
## master #20558 +/- ##
=============================================
- Coverage 75.742% 75.737% -0.006%
=============================================
Files 673 673
Lines 174499 174499
Branches 41205 41205
=============================================
- Hits 132170 132161 -9
- Misses 36607 36611 +4
- Partials 5722 5727 +5 |
@bjodah @czgdp1807 added regression tests |
Tests are passing. Will merge tomorrow if no objections raised. Thanks for the contributions. |
References to other Issues or PRs
Fixes #20557
Brief description of what is fixed or changed
Previous implementation used string conversion for first argument. Fixed correctly using using codeprinting
Other comments
Release Notes