sets: made Rationals.contains(float) indeterminate #20565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rminate Currently, sympy.Rationals.contains(0.5) evaluates to False. This patch instead evaluates the expression to indeterminate based on the following logic: a float represents an approximation of an underlying number that could be either rational or irrational. In relation with this change, I have also adjusted a test case that currently asserts sympy.Rationals.contains(1.0) evaluates to False. This test was changed to assert that the expression above evaluates to indeterminate instead of False or True.
|
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
|
Travis build failed for transient reason, so re-doing pull request as suggested in chat. |
Codecov Report
@@ Coverage Diff @@
## master #20565 +/- ##
=============================================
+ Coverage 75.741% 75.772% +0.031%
=============================================
Files 673 673
Lines 174499 174497 -2
Branches 41205 41204 -1
=============================================
+ Hits 132168 132221 +53
+ Misses 36611 36561 -50
+ Partials 5720 5715 -5 |
sympy/sets/tests/test_fancysets.py
Outdated
| @@ -1046,7 +1046,8 @@ def test_Rationals(): | |||
| Rational(1, 3), 3, Rational(-1, 3), -3, Rational(2, 3)] | |||
| assert Basic() not in S.Rationals | |||
| assert S.Half in S.Rationals | |||
| assert 1.0 not in S.Rationals | |||
| assert S.Rationals.contains(0.5) is not True | |||
| assert S.Rationals.contains(0.5) is not False | |||
There was a problem hiding this comment.
It would be better to do:
assert Rationals.contains(0.5) == Contains(0.5, Rationals, evaluate=False)
Previously, the test was checking whether Rationals.contains(0.5) was neither false or true. Now, I've adjusted it slightly to more clearly evaluate whether Rationals.contains is indeterminate.
|
Closing and reopening to restart the tests. |
|
This looks good. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sympy.Rationals.contains(0.5) evaluates to False.
This patch instead evaluates the expression to indeterminate
based on the following logic: a float represents an approximation
of an underlying number that could be either rational or irrational.
In relation with this change, I have also adjusted a test case
that currently asserts sympy.Rationals.contains(1.0) evaluates
to False. This test was changed to assert that the expression
above evaluates to indeterminate instead of False or True.
Fixes #20364
Current master behavior:
In [1]: sympy.Rationals.contains(0.5)
Patched behavior:
In [1]: sympy.Rationals.contains(0.5)
References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
Release Notes