Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent matrix output versus tuple output FIXED #20606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ABKor752
Copy link

@ABKor752 ABKor752 commented Dec 15, 2020

References to other Issues or PRs

Fixes #19725

Brief description of what is fixed or changed

The issue in question talked about there being inconsistent outputs of matrices; some matrices were printed as tuples while others were printed as normal Sympy-style matrices. To the best of my ability, I have made the output of matrices consistent, and if there is inconsistency elsewhere in the vector module, I have written a function which can be called to turn the tuple into a proper matrix.

Other comments

This is the same pull request as #20559. The reason for this additional pull request is to fix an issue with the entire test_coordsysrect.py being modified by the commits.

Release Notes

  • vector
    • Added a function to allow for consistency across matrix printing in the vector module.

@sympy-bot
Copy link

sympy-bot commented Dec 15, 2020

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • vector
    • Added a function to allow for consistency across matrix printing in the vector module. (#20606 by @ABKor752)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. --> Fixes #19725


#### Brief description of what is fixed or changed
The issue in question talked about there being inconsistent outputs of matrices; some matrices were printed as tuples while others were printed as normal Sympy-style matrices. To the best of my ability, I have made the output of matrices consistent, and if there is inconsistency elsewhere in the vector module, I have written a function which can be called to turn the tuple into a proper matrix.

#### Other comments
This is the same pull request as #20559. The reason for this additional pull request is to fix an issue with the entire test_coordsysrect.py being modified by the commits.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* vector
    * Added a function to allow for consistency across matrix printing in the vector module.
<!-- END RELEASE NOTES -->

@oscarbenjamin
Copy link
Contributor

@moorepants can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector module - inconsistencies
4 participants