Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dcumentation for ecm and qs functions #20820

Merged
merged 14 commits into from Feb 16, 2021
Merged

Conversation

mayankray2020
Copy link
Contributor

@mayankray2020 mayankray2020 commented Jan 18, 2021

References to other Issues or PRs

Taking over #19971

  • ntheory
    • Added documentation of ecm and qs functions

@sympy-bot
Copy link

sympy-bot commented Jan 18, 2021

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
Taking over #19971 
<!-- BEGIN RELEASE NOTES -->
* ntheory
  * Added documentation of ecm and qs functions
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@mayankray2020 mayankray2020 changed the title Q rst Added dcumentation for ecm and qs Jan 18, 2021
@mayankray2020 mayankray2020 changed the title Added dcumentation for ecm and qs Added dcumentation for ecm and qs functions Jan 18, 2021
@mayankray2020
Copy link
Contributor Author

@abh2k @czgdp1807

@abhinav-anand-addepar
Copy link
Member

@Yathartha22 Please review this.

@abhinav-anand-addepar
Copy link
Member

abhinav-anand-addepar commented Jan 31, 2021

I have given a minor suggestion. Apart from this it seem good.

@mayankray2020
Copy link
Contributor Author

@czgdp1807 Can we merge this??

@mayankray2020
Copy link
Contributor Author

@czgdp1807 can this be merged??

@czgdp1807 czgdp1807 merged commit b780f8b into sympy:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants