Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xi function #20901

Merged
merged 9 commits into from Mar 13, 2021
Merged

Xi function #20901

merged 9 commits into from Mar 13, 2021

Conversation

mayankray2020
Copy link
Contributor

@mayankray2020 mayankray2020 commented Feb 3, 2021

References to other Issues or PRs

Taking over #18483

  • functions
    • riemaan xi function

@sympy-bot
Copy link

sympy-bot commented Feb 3, 2021

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Taking over #18483 

<!-- BEGIN RELEASE NOTES -->
* functions
  * riemaan xi function
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@0sidharth
Copy link
Member

You should add the function name to sympy/__init__.py also.

@0sidharth
Copy link
Member

You also need to add to sympy/core/tests/test_args.py

@mayankray2020
Copy link
Contributor Author

@0sidharth @czgdp1807 please review this.

@0sidharth
Copy link
Member

LGTM.

@mayankray2020
Copy link
Contributor Author

@0sidharth @czgdp1807 is it ready to merge??

@abhinav-anand-addepar
Copy link
Member

LGTM.

@mayankray2020
Copy link
Contributor Author

@czgdp1807 please review.

@oscarbenjamin
Copy link
Contributor

Looks good

@oscarbenjamin oscarbenjamin merged commit 01e9771 into sympy:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants