Implemented expand_trig for csch, sech and coth #21567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h cases handled; 1. argument is a sum of terms, 2. (for coth) argument is an integer multiple of another expression
|
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.9. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
smichr
reviewed
Jun 4, 2021
| @@ -327,6 +327,11 @@ def test_coth(): | |||
| x = Symbol('x', extended_real=True) | |||
| assert coth(x).as_real_imag(deep=False) == (coth(x), 0) | |||
|
|
|||
| assert expand_trig(coth(2*x)) == (coth(x)**2+1)/(2*coth(x)) | |||
jksuom
reviewed
Jun 4, 2021
Comment on lines
892
to
893
| Yg = numbered_symbols('Y') | ||
| Y = [next(Yg) for i in range(n)] |
There was a problem hiding this comment.
It should be possible to use CX instead of Y.
smichr
reviewed
Jun 5, 2021
smichr
reviewed
Jun 5, 2021
smichr
reviewed
Jun 5, 2021
smichr
reviewed
Jun 5, 2021
smichr
reviewed
Jun 5, 2021
smichr
reviewed
Jun 5, 2021
smichr
reviewed
Jun 5, 2021
smichr
reviewed
Jun 5, 2021
|
Thank you for the feedback. I see you have merged it with the changes. I have looked through what you have done and I can use this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21495
Implemented expand_trig for csch, sech and coth. Both cases handled; 1. argument is a sum of terms, 2. (for coth) argument is an integer multiple of another expression