Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/function: Fix regression in derivative (1.10 branch) #23166

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

oscarbenjamin
Copy link
Collaborator

References to other Issues or PRs

Same as #23162 but for the 1.10 branch.

Brief description of what is fixed or changed

Other comments

Release Notes

NO ENTRY

ThePauliPrinciple and others added 2 commits February 25, 2022 17:52
The arguments are ran through `_sympify` so that types registered
in `converter` are also allowed.
@sympy-bot
Copy link

Hi, I am the SymPy bot (v163). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

Same as #23162 but for the 1.10 branch.


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@oscarbenjamin oscarbenjamin added this to the SymPy 1.10 milestone Feb 25, 2022
@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

       before           after         ratio
     [b7f56b0a]       [bd490296]
-         202±4ms          132±2ms     0.65  sum.TimeSum.time_doit

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [907895ac]       [b7f56b0a]
-         298±4ms          184±4ms     0.62  large_exprs.TimeLargeExpressionOperations.time_subs
-      19.8±0.6ms       13.1±0.6ms     0.66  matrices.TimeMatrixExpression.time_MatAdd_doit
-         279±5μs          127±2μs     0.46  matrices.TimeMatrixExpression.time_MatMul
-      18.4±0.4ms       9.75±0.1ms     0.53  matrices.TimeMatrixExpression.time_MatMul_doit
-      5.79±0.03s          418±5ms     0.07  polygon.PolygonArbitraryPoint.time_bench01
+     4.46±0.07ms       7.37±0.1ms     1.65  solve.TimeMatrixOperations.time_det(4, 2)
+      4.55±0.1ms       7.30±0.1ms     1.61  solve.TimeMatrixOperations.time_det_bareiss(4, 2)
+      49.0±0.7ms         89.1±1ms     1.82  solve.TimeMatrixSolvePyDySlow.time_linsolve(1)
+      52.9±0.9ms         88.1±2ms     1.66  solve.TimeMatrixSolvePyDySlow.time_solve(1)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants