Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contiguous numbers in rsolve #23837

Merged
merged 1 commit into from Jul 28, 2022
Merged

contiguous numbers in rsolve #23837

merged 1 commit into from Jul 28, 2022

Conversation

smichr
Copy link
Member

@smichr smichr commented Jul 26, 2022

  • solvers
    • rsolve_poly will return results with contiguously numbered constants

@sympy-bot
Copy link

sympy-bot commented Jul 26, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • solvers
    • rsolve_poly will return results with contiguously numbered constants (#23837 by @smichr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- BEGIN RELEASE NOTES -->
* solvers
  * `rsolve_poly` will return results with contiguously numbered constants
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@smichr smichr marked this pull request as ready for review July 26, 2022 23:36
@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@smichr smichr changed the title contiguous numbers in rsolve; set=True format preserved contiguous numbers in rsolve Jul 27, 2022
@smichr
Copy link
Member Author

smichr commented Jul 27, 2022

blocked by #23840

@smichr smichr force-pushed the e3 branch 3 times, most recently from 0dd8704 to 6ab9aaf Compare July 27, 2022 15:38
@smichr
Copy link
Member Author

smichr commented Jul 27, 2022

@oscarbenjamin , any idea why the optional dependency test is marked as being required? Or is there some other problem?

@smichr smichr closed this Jul 27, 2022
auto-merge was automatically disabled July 27, 2022 23:54

Pull request was closed

@smichr smichr reopened this Jul 27, 2022
@oscarbenjamin
Copy link
Contributor

any idea why the optional dependency test is marked as being required?

That job does not usually fail. I've made it not required for now.

Or is there some other problem?

See #23847

@smichr smichr merged commit 57d875d into sympy:master Jul 28, 2022
@smichr smichr deleted the e3 branch July 28, 2022 18:35
@oscarbenjamin
Copy link
Contributor

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants