Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve set=True format #23840

Merged
merged 2 commits into from Jul 27, 2022
Merged

preserve set=True format #23840

merged 2 commits into from Jul 27, 2022

Conversation

smichr
Copy link
Member

@smichr smichr commented Jul 27, 2022

References to other Issues or PRs

Brief description of what is fixed or changed

make sure to keep set=True format even when there is no solution and always include the symbols

select this format with internal use where the tuple solution is needed

Other comments

Release Notes

  • solvers
    • solve will always return a tuple (sym, sol) when set=True, even if sol is empty

@sympy-bot
Copy link

sympy-bot commented Jul 27, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • solvers
    • solve will always return a tuple (sym, sol) when set=True, even if sol is empty (#23840 by @smichr)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

make sure to keep set=True format even when there is no solution and always include the symbols

select this format with internal use where the tuple solution is needed

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
  * `solve` will always return a tuple `(sym, sol)` when `set=True`, even if `sol` is empty

<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@smichr smichr marked this pull request as ready for review July 27, 2022 06:59
This was referenced Jul 27, 2022
@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin
Copy link
Contributor

Looks good to me.

@smichr smichr merged commit c11eff8 into sympy:master Jul 27, 2022
@smichr smichr deleted the e1 branch July 27, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants