Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

physics/continuum_mechanics: Added sympy functions for cos and sin instead of using the math module #24039

Merged
merged 1 commit into from Sep 14, 2022

Conversation

AdvaitPote
Copy link
Member

References to other Issues or PRs

Fixes #24038

Brief description of what is fixed or changed

Replaced math.sin and math.cos by their respective SymPy functions. This way Symbolic functions are used for calculations in the solve method.

Other comments

Release Notes

  • physics.continuum_mechanics
    • Added Symbolic Functions in the solve method for calculations instead of the math module

@sympy-bot
Copy link

sympy-bot commented Sep 9, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • physics.continuum_mechanics
    • Added Symbolic Functions in the solve method for calculations instead of the math module (#24039 by @AdvaitPote)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #24038

#### Brief description of what is fixed or changed
Replaced `math.sin` and `math.cos` by their respective SymPy functions. This way Symbolic functions are used for calculations in the `solve` method. 

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* physics.continuum_mechanics
  * Added Symbolic Functions in the `solve` method for calculations instead of the `math` module
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@AdvaitPote AdvaitPote changed the title added sympy functions for cos and sin instead of using the math module physics/conitnuum_mechanics: Added sympy functions for cos and sin instead of using the math module Sep 9, 2022
@AdvaitPote AdvaitPote changed the title physics/conitnuum_mechanics: Added sympy functions for cos and sin instead of using the math module physics/continuum_mechanics: Added sympy functions for cos and sin instead of using the math module Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [69532d2e]
     <sympy-1.11.1^0>                 
-         992±4μs          626±1μs     0.63  solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
-     2.84±0.01ms         1.16±0ms     0.41  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-     5.68±0.01ms         1.71±0ms     0.30  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@moorepants
Copy link
Member

LGTM. I recommend adding examples and tests with only symbolics in a future pull request also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truss - compute forces using sympy functions rather math module
3 participants