-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a wrong behavior (parse of power negative arguments) of function parse_mathematica. #24224
base: master
Are you sure you want to change the base?
Conversation
Upload pull_request.md file.
Fixed a wrong behavior (parse of power negative arguments) of function parse_mathematica.
✅ Hi, I am the SymPy bot (v169). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12. Click here to see the pull request description that was parsed.
|
🟠Hi, I am the SymPy bot (v169). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files: The following commits delete files:
If these files were added/deleted on purpose, you can ignore this message. |
The authors test has failed. A line should be added in the .mailmap file:
|
A test should be added for the changed behaviour. |
The commits will need to be squashed because one commit removes a file and another adds it back again. |
I'm going to mark this PR as a draft. Feel free to change it to ready for review once the issues above are addressed. |
Is this PR still inprogress? there are redundant files that you have attached with the PR. |
@TheDeveloperDino I can work on this, if you are not developing this.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is redundant, I guess you have added a testing file with your PR.
print("Error test: " + str(result[2])) | ||
|
||
|
||
#def parse(self, s): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better if you remove this commented code.
References to other Issues or PRs
Fixes #24150
Brief description of what is fixed or changed
Fixed wrong behavior of function parse_mathematica in module parsing.mathematica.
In function parse changed statement _mathematica_op_precedence as follow:
Rule of power transferred before rule of prefix operators.
Example of result behavior:
Other comments
Release Notes
parse_mathematica("2^-10*x")
givex/1024
instead of2**(-10*x)
.