Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed limit(x**n, x, -oo) Giving -oo As Answer Irrespective Of Odd/Even n #24458

Merged
merged 4 commits into from Jan 5, 2023

Conversation

faze-geek
Copy link
Contributor

@faze-geek faze-geek commented Jan 1, 2023

References to other Issues or PRs

Fixes #8634
Closes #22712

Brief description of what is fixed or changed

Returns output dependent on 'n' (hence varies when n is odd/even) instead of -oo.

P.S. - This is a reproduction of #22712 which has already been reviewed to be correct by a couple of maintainers of the series module. It was contributed before the mailmap was introduced hence I am repeating it as suggested here .

On master -

>>> n = Symbol('n', integer=True, positive=True)  # could be 2 or 3...
>>> limit(x**n, x, -oo)
-oo

On branch -

>>> limit(x**n, x, -oo)
oo*sign((-1)**n)

Other comments

Release Notes

  • series
    • Fixes limit at negative infinity considering odd or even power.

@sympy-bot
Copy link

sympy-bot commented Jan 1, 2023

Hi, I am the SymPy bot (v169). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • series
    • Fixes limit at negative infinity considering odd or even power. (#24458 by @faze-geek)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #8634
Closes #22712 

#### Brief description of what is fixed or changed
Returns output dependent on 'n' (hence varies when n is odd/even) instead of -oo. 

P.S. - This is a reproduction of #22712 which has already been reviewed to be correct by a couple of maintainers of the `series` module. It was contributed before the mailmap was introduced hence I am repeating it as suggested [here](https://github.com/sympy/sympy/pull/22712#discussion_r922663308) .

On master - 
```
>>> n = Symbol('n', integer=True, positive=True)  # could be 2 or 3...
>>> limit(x**n, x, -oo)
-oo
```

On branch -
```
>>> limit(x**n, x, -oo)
oo*sign((-1)**n)
```
#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* series
  * Fixes limit at negative infinity considering odd or even power.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [40b1af74]
     <sympy-1.11.1^0>                 
-      3.27±0.1ms      1.39±0.04ms     0.42  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-      6.63±0.2ms       2.11±0.1ms     0.32  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@smichr smichr merged commit a380cfa into sympy:master Jan 5, 2023
@faze-geek faze-geek deleted the Fix_8634 branch January 5, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit(x**n, x, -oo) is sometimes wrong
4 participants