Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the grammar in function examples of Beam3D #25008

Merged
merged 7 commits into from Apr 2, 2023

Conversation

JebronLames32
Copy link
Contributor

@JebronLames32 JebronLames32 commented Apr 2, 2023

References to other Issues or PRs

Brief description of what is fixed or changed

The example problems in most functions had a common grammatical error.
That has been changed in the respective functions.
The list of functions where change is made are:
plot_shear_force, plot_bending_moment, plot_slope,plot_deflection,
plot_loading_results, plot_shear_stress, max_shear_force, max_bending_moment,
max_deflection.

Other comments

NO ENTRY

Release Notes

NO ENTRY

… Examples

Changed the grammar in functions plot_shear_force, plot_bending_moment, plot_slope,
plot_deflection, plot_loading_results, plot_shear_stress, max_shear_force, max_bending_moment,
max_deflection.

Before change:
There is a beam of length 20 meters. It it supported by rollers
        at of its end.
After change:
There is a beam of length 20 meters. It it supported by rollers
        at both of its ends.
@sympy-bot
Copy link

sympy-bot commented Apr 2, 2023

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
The example problems in most functions had a common grammatical error.
That has been changed in the respective functions. 
The list of functions where change is made are:
plot_shear_force, plot_bending_moment, plot_slope,plot_deflection, 
plot_loading_results, plot_shear_stress, max_shear_force, max_bending_moment,
max_deflection.


#### Other comments
NO ENTRY


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

Adding a newline at the end of code required to pass the code quality check
@@ -3641,3 +3641,4 @@ def max_deflection(self):
max_def.append(self._max_deflection('y'))
max_def.append(self._max_deflection('z'))
return max_def

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra line.

@moorepants
Copy link
Member

Thanks for the fix. Can you fully correct the sentences and remove the extra line?

Also, this does not need a release notes, use "NO ENTRY".

JebronLames32 and others added 2 commits April 2, 2023 14:37
fix more grammatical mistakes in the examples.

Co-authored-by: Jason K. Moore <moorepants@gmail.com>
Remove the extra line.
@JebronLames32
Copy link
Contributor Author

Thanks for the fix. Can you fully correct the sentences and remove the extra line?

Also, this does not need a release notes, use "NO ENTRY".

Done. Please check now.

@moorepants
Copy link
Member

You need to address this too:

This author is not included in the .mailmap file:
Abhinav R Cillanki <95158195+JebronLames32@users.noreply.github.com>

The .mailmap file needs to be updated because there are commits with
unrecognised author/email metadata.

        For instructions on updating the .mailmap file see:
https://docs.sympy.org/dev/contributing/new-contributors-guide/workflow-process.html#mailmap-instructions

The following authors will be added to the AUTHORS file at the time of
the next SymPy release.

@JebronLames32
Copy link
Contributor Author

Made the change @moorepants

@1e9abhi1e10
Copy link
Contributor

Made the change @moorepants

you need to run the following command python bin/mailmap_check.py after adding your name and email in the .mailmap file
read here for instructions.

@JebronLames32
Copy link
Contributor Author

Made the change @moorepants

you need to run the following command python bin/mailmap_check.py after adding your name and email in the .mailmap file read here for instructions.

Thanks a lot

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [271ca9f6]       [9e855bb8]
-         121±3ms         77.2±1ms     0.64  integrate.TimeIntegrationRisch02.time_doit(10)
-         121±4ms         73.8±3ms     0.61  integrate.TimeIntegrationRisch02.time_doit_risch(10)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@moorepants moorepants merged commit 42efa07 into sympy:master Apr 2, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants