New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the grammar in function examples of Beam3D #25008
Conversation
… Examples Changed the grammar in functions plot_shear_force, plot_bending_moment, plot_slope, plot_deflection, plot_loading_results, plot_shear_stress, max_shear_force, max_bending_moment, max_deflection. Before change: There is a beam of length 20 meters. It it supported by rollers at of its end. After change: There is a beam of length 20 meters. It it supported by rollers at both of its ends.
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
Adding a newline at the end of code required to pass the code quality check
@@ -3641,3 +3641,4 @@ def max_deflection(self): | |||
max_def.append(self._max_deflection('y')) | |||
max_def.append(self._max_deflection('z')) | |||
return max_def | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra line.
Thanks for the fix. Can you fully correct the sentences and remove the extra line? Also, this does not need a release notes, use "NO ENTRY". |
fix more grammatical mistakes in the examples. Co-authored-by: Jason K. Moore <moorepants@gmail.com>
Remove the extra line.
Done. Please check now. |
You need to address this too:
|
Made the change @moorepants |
you need to run the following command |
Thanks a lot |
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[271ca9f6] [9e855bb8]
- 121±3ms 77.2±1ms 0.64 integrate.TimeIntegrationRisch02.time_doit(10)
- 121±4ms 73.8±3ms 0.61 integrate.TimeIntegrationRisch02.time_doit_risch(10)
Full benchmark results can be found as artifacts in GitHub Actions |
References to other Issues or PRs
Brief description of what is fixed or changed
The example problems in most functions had a common grammatical error.
That has been changed in the respective functions.
The list of functions where change is made are:
plot_shear_force, plot_bending_moment, plot_slope,plot_deflection,
plot_loading_results, plot_shear_stress, max_shear_force, max_bending_moment,
max_deflection.
Other comments
NO ENTRY
Release Notes
NO ENTRY